This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
App usages over 16 years (EXPOSUREAPP-1781) #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobmoellerdev
changed the title
kolyaopahle
suggested changes
Aug 20, 2020
|
|
||
| <variable | ||
| name="tracingViewModel" | ||
| type="de.rki.coronawarnapp.ui.viewmodel.TracingViewModel" /> |
|
|
||
| <data> | ||
|
|
||
| <import type="de.rki.coronawarnapp.util.formatter.FormatterHelper" /> |
There was a problem hiding this comment.
Formatters seem unused
|
|
||
| <import type="de.rki.coronawarnapp.util.formatter.FormatterHelper" /> | ||
|
|
||
| <import type="de.rki.coronawarnapp.util.formatter.FormatterAccessibilityHelper" /> |
There was a problem hiding this comment.
Formatters seem unused
|
|
||
| <import type="de.rki.coronawarnapp.util.formatter.FormatterAccessibilityHelper" /> | ||
|
|
||
| <import type="android.view.View" /> |
| ###################################### --> | ||
|
|
||
| <!-- XACT: onboarding(sixteen) title --> | ||
| <string name="sixteen_title_text">"App Nutzung ab 16 Jahren"</string> |
There was a problem hiding this comment.
Default strings should be empty
| <string name="sixteen_title_text">"App Nutzung ab 16 Jahren"</string> | ||
|
|
||
| <!-- XACT: onboarding(sixteen) title --> | ||
| <string name="sixteen_description_text">"Die App richtet sich an Personen, die sich in Deutschland aufhalten und mindestens 16 Jahre alt sind."</string> |
There was a problem hiding this comment.
Default strings should be empty
| @@ -198,6 +205,14 @@ | |||
| <item name="android:textColor">@color/colorTextPrimary1</item> | |||
| </style> | |||
|
|
|||
| <style name="headline6Sixteen" parent="@style/TextAppearance.MaterialComponents.Headline6"> | |||
| <item name="android:textColor">@color/colorTextEmphasizedButton</item> | |||
There was a problem hiding this comment.
Is there a non button reference you could use?
| </style> | ||
|
|
||
| <style name="subtitleSixteen" parent="@style/TextAppearance.MaterialComponents.Subtitle1"> | ||
| <item name="android:textColor">@color/colorTextEmphasizedButton</item> |
There was a problem hiding this comment.
Is there a non button reference you could use?
|
fixed |
kolyaopahle
approved these changes
Aug 21, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
|
EXPOSUREAPP-2092 |
Closed
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.itc.sap.com/browse/EXPOSUREAPP-1781#add-comment