Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Improve transaction logging #1061

Merged
merged 6 commits into from
Aug 27, 2020
Merged

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented Aug 21, 2020

Add explicit tags to allow for type specific filtering.
Move OkHttp webrequest logging to VERBOSE (from INFO).

This also fixes a few broken log statements we had, i.e.

Timber.v(TAG, msg) // <- would only print TAG, msg treated as input for non-existend placeholders.
// instead of
Timber.tag(TAG).v(msg)

Spawned by EXPOSUREAPP-2267.

Add explicit tags to allow for type specific filtering and fix bad log statements.
Move OkHttp web logging to VERBOSE (from INFO).
@d4rken d4rken added enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers labels Aug 21, 2020
@d4rken d4rken requested a review from a team August 21, 2020 21:38
jakobmoellerdev and others added 2 commits August 25, 2020 13:19
# Conflicts:
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/transaction/RiskLevelTransaction.kt
@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

73.8% 73.8% Coverage
0.0% 0.0% Duplication

@jakobmoellerdev jakobmoellerdev merged commit 024cb66 into dev Aug 27, 2020
@jakobmoellerdev jakobmoellerdev deleted the feat/improved-transaction-logging branch August 27, 2020 07:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of an existing feature maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants