Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix: Replaced brackets with leading # to match website faq structure (EXPOSUREAPP-2261) #1074

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

harambasicluka
Copy link
Contributor

No description provided.

Copy link
Contributor

@vaubaehn vaubaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harambasicluka,
~do you plan to change the anchors in the FAQs?
Otherwise I'd suggest to change
message += "#API$apiStatusCode"
as the current links are
https://www.coronawarn.app/de/faq/#API10
and
https://www.coronawarn.app/de/faq/#API39508
Kind regards, V.

Edit: FAQ's anchor for API17 is
https://www.coronawarn.app/de/faq/#cause_3
So, at least this anchor needs to be modified. If all 3 anchors are modified, proposed code of this PR can stay as it is, for sure.
But maybe that's already on your task list, and I'm only throwing hot air 😊 ~~

Edit 2:
Hot air... Now found the much more sophisticated change PR for website by @tkowark

@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@harambasicluka
Copy link
Contributor Author

Hi @vaubaehn ,

this is aligned with the website team, corresponding ticket corona-warn-app/cwa-website#314

Cheers,
Luka

@harambasicluka harambasicluka linked an issue Aug 28, 2020 that may be closed by this pull request
3 tasks
@vaubaehn
Copy link
Contributor

Hi @vaubaehn ,

this is aligned with the website team, corresponding ticket corona-warn-app/cwa-website#314

Cheers,
Luka

Hi @harambasicluka , thanks for your feedback!
I hope I didn't bring up any disturbance or confusion by my comments...
I was tracking that issue, since it was introduced in #864 , so I had an eye on it :) and thought only of a fix inside the app. Just found the cool server change later, and then didn't erase my comment here as you might have already been notified via e-mail...
Thanks again, and enjoy your week-end!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers sprint5
Projects
None yet
3 participants