This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Improve Explanation for usage of location services (EXPOSUREAPP-2384) #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janetback
suggested changes
Sep 10, 2020
|
|
d4rken
suggested changes
Sep 14, 2020
| } | ||
|
|
||
| private fun setUrl() { | ||
| setUrl( |
There was a problem hiding this comment.
This crashes when the language is not set to german (i.e. English), because the default translations in strings.xml are missing the replacement marker "FAQ", and the URL.
@harambasicluka ping
Process: de.rki.coronawarnapp.dev, PID: 8741
android.view.InflateException: Binary XML file line #88 in de.rki.coronawarnapp.dev:layout/fragment_settings_tracing: Binary XML file line #74 in de.rki.coronawarnapp.dev:layout/include_tracing_status_card_location: Error inflating class de.rki.coronawarnapp.ui.view.LocationTracingStatusCardBodyTextView
Caused by: android.view.InflateException: Binary XML file line #74 in de.rki.coronawarnapp.dev:layout/include_tracing_status_card_location: Error inflating class de.rki.coronawarnapp.ui.view.LocationTracingStatusCardBodyTextView
Caused by: java.lang.reflect.InvocationTargetException
at java.lang.reflect.Constructor.newInstance0(Native Method)
at java.lang.reflect.Constructor.newInstance(Constructor.java:343)
at android.view.LayoutInflater.createView(LayoutInflater.java:854)
at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:1006)
at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:961)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:1123)
at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:1084)
at android.view.LayoutInflater.parseInclude(LayoutInflater.java:1263)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:1119)
at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:1084)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:1126)
at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:1084)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:1126)
at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:1084)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:1126)
at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:1084)
at android.view.LayoutInflater.inflate(LayoutInflater.java:682)
at android.view.LayoutInflater.inflate(LayoutInflater.java:534)
at androidx.databinding.DataBindingUtil.inflate(DataBindingUtil.java:126)
at androidx.databinding.ViewDataBinding.inflateInternal(ViewDataBinding.java:1368)
at de.rki.coronawarnapp.databinding.FragmentSettingsTracingBinding.inflate(FragmentSettingsTracingBinding.java:149)
at de.rki.coronawarnapp.databinding.FragmentSettingsTracingBinding.inflate(FragmentSettingsTracingBinding.java:135)
at de.rki.coronawarnapp.ui.settings.SettingsTracingFragment.onCreateView(SettingsTracingFragment.kt:56)
at androidx.fragment.app.Fragment.performCreateView(Fragment.java:2698)
at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:320)
at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1187)
at androidx.fragment.app.FragmentManager.addAddedFragments(FragmentManager.java:2224)
at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1997)
at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1953)
at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1849)
at androidx.fragment.app.FragmentManager$4.run(FragmentManager.java:413)
at android.os.Handler.handleCallback(Handler.java:883)
at android.os.Handler.dispatchMessage(Handler.java:100)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:7397)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:935)
Caused by: java.lang.IndexOutOfBoundsException: setSpan (-1 ... 2) starts before 0
at android.text.SpannableStringInternal.checkRange(SpannableStringInternal.java:496)
at android.text.SpannableStringInternal.setSpan(SpannableStringInternal.java:196)
at android.text.SpannableStringInternal.setSpan(SpannableStringInternal.java:183)
at android.text.SpannableString.setSpan(SpannableString.java:60)
at de.rki.coronawarnapp.util.ViewsKt.setUrl(Views.kt:41)
E/AndroidRuntime: at de.rki.coronawarnapp.ui.view.LocationTracingStatusCardBodyTextView.setUrl(LocationTracingStatusCardBodyTextView.kt:28)
at de.rki.coronawarnapp.ui.view.LocationTracingStatusCardBodyTextView.<init>(LocationTracingStatusCardBodyTextView.kt:16)
... 38 more
I/Process: Sending signal. PID: 8741 SIG: 9There was a problem hiding this comment.
I would recommend to return the string without the link if the replacement marker isn't part of the string. after the translation it should be part of it.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated german location text and also enabled links for this text.
Steps to reproduce