This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Reduce boilerplate code for fragment view setup #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also made another addition to our |
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/SubmissionTanFragment.kt
d4rken
commented
Sep 16, 2020
| @@ -137,6 +137,14 @@ android { | |||
| jvmTarget = "1.8" | |||
| } | |||
|
|
|||
| def jvmCompilerArgs = ["-Xno-kotlin-nothing-value-exception"] | |||
|
|
|||
| tasks.withType(org.jetbrains.kotlin.gradle.dsl.KotlinJvmCompile) { | |||
There was a problem hiding this comment.
Workaround for possible bug in mockk+kotlin1.4:
ralfgehrer
reviewed
Sep 17, 2020
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/ui/ViewBindingExtensions.kt
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/SubmissionIntroFragment.kt
Show resolved
Hide resolved
...na-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/SubmissionQRCodeScanFragment.kt
Outdated
Show resolved
Hide resolved
...main/java/de/rki/coronawarnapp/ui/submission/SubmissionResultPositiveOtherWarningFragment.kt
Outdated
Show resolved
Hide resolved
...na-Warn-App/src/main/java/de/rki/coronawarnapp/ui/submission/SubmissionTestResultFragment.kt
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/information/InformationFragment.kt
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/information/InformationContactFragment.kt
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/information/InformationAboutFragment.kt
Show resolved
Hide resolved
Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/TestForAPIFragment.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/TestForAPIFragment.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # .idea/codeStyles/Project.xml # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/TestRiskLevelCalculationFragment.kt # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/api/ui/TestForAPIFragment.kt
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Taking #928 one step further. Reducing fragment view instantion/binding to 1 LOC.
Upgrading to Kotlin
1.4.0which is also the current default for AndroidStudio4.0.How to test
Fragment(<layoutfile>)matches thebinding: <ViewBindingClass> by viewmodels()