Improve keyfile checksum handling #1181

d4rken · 2020-09-18T10:13:11Z

Description

Make checksum retrieval the responsibility of DiagnosisKeyServer instead of KeyFileDownloader (cleaner)
Favor the servers MD5 over our own (but use it as fallback) (when we add key validation, we ideally want the server provided checksum)

Refactor MD5 extraction to be part of `DiagnosisKeyServer`'s responsibility.

The base branch was changed.

Prefer server MD5 over local one for downloaded files.

049aeb7

Refactor MD5 extraction to be part of `DiagnosisKeyServer`'s responsibility.

d4rken added maintainers Tag pull requests created by maintainers 1.5.0 labels Sep 18, 2020

d4rken requested a review from a team September 18, 2020 10:13

chris-cwa previously approved these changes Sep 18, 2020

View reviewed changes

Base automatically changed from feature/interoperability to release/1.5.x September 18, 2020 13:25

d4rken requested a review from janetback as a code owner September 18, 2020 13:25

d4rken changed the base branch from release/1.5.x to release/1.4.x September 18, 2020 13:26

d4rken changed the base branch from release/1.4.x to release/1.5.x September 18, 2020 13:27

d4rken closed this Sep 18, 2020

d4rken reopened this Sep 18, 2020

d4rken changed the base branch from release/1.5.x to fix/interopsquash September 18, 2020 13:46

d4rken changed the base branch from fix/interopsquash to release/1.5.x September 18, 2020 13:47

d4rken changed the base branch from release/1.5.x to feature/interoperability-backend September 18, 2020 13:58

d4rken changed the base branch from feature/interoperability-backend to release/1.5.x September 18, 2020 13:58

d4rken merged commit fc5e57c into release/1.5.x Sep 18, 2020

d4rken deleted the fix/checksum-storage branch September 18, 2020 19:03

harambasicluka added this to the 1.5.0 milestone Oct 6, 2020

harambasicluka removed the 1.5.0 label Oct 6, 2020