This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Remove QuotaCalculator from hotfix 1.3.1 #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4rken
added
bug
harambasicluka
approved these changes
Sep 21, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
jakobmoellerdev
approved these changes
Sep 21, 2020
jakobmoellerdev
deleted the
fix/hotfix-1.3.1-remove-quotacalculation
branch
d4rken
added a commit
that referenced
this pull request
Sep 21, 2020
d4rken
added a commit
that referenced
this pull request
Sep 22, 2020
* QuotaCalculator V2 * Add extra logging for transaction and worker exceptions. (#1195) (EXPOSUREAPP-2640) * Remove QuotaCalculation due to unexpected sideeffects. (#1196) (EXPOUSREAPP-2640) * Fix klint/sourceCheck. * Add test for first initialization. * Add visibility modifier * Simplify quota reset time calculation and extend tests for edge cases. * Reduce impact of quota check to a warning for 1.4. Add tests for silent quota check and configuration fallback behavior. * Addressed PR comments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The QuotaCalculator had unexpected sideeffects which will be fixed in a future release.