This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Handle App Config uniformly with caching (EXPOSUREAPP-2747) #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use "files" instead of "cache" for storing our AppConfigApiTest. * Add "files" to "cache" migration. * Refactor CDN related code into an independent "environment module". TODO: UnitTests, Fallback behavior even if cached AppConfig is stale.
d4rken
added
enhancement
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/appconfig/AppConfigProvider.kt
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/environment/download/DownloadCDNModule.kt
Show resolved
Hide resolved
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/di/ApplicationComponent.kt
jakobmoellerdev
previously approved these changes
Sep 24, 2020
ralfgehrer
previously approved these changes
Sep 25, 2020
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/appconfig/AppConfigStorage.kt
Show resolved
Hide resolved
Corona-Warn-App/src/test/java/de/rki/coronawarnapp/appconfig/AppConfigApiTest.kt
Outdated
Show resolved
Hide resolved
d4rken
added a commit
that referenced
this pull request
Sep 25, 2020
…ies. TODO: Unit tests, pull supportedCountries from AppConfig (waiting for #1213)
2 tasks
d4rken
dismissed stale reviews from ralfgehrer and jakobmoellerdev
via
9cf0980
|
Kudos, SonarCloud Quality Gate passed!
|
d4rken
added a commit
that referenced
this pull request
Sep 30, 2020
* Update protobuf format * Addition of contentToFederation and visistedCountries/supportedCountries. TODO: Unit tests, pull supportedCountries from AppConfig (waiting for #1213) * Fix invalid package being assigned. This would break daggers annotation processing as the class could not be resolved. * Improved existing and implemented new tests. * Fixed test regression due to refactoring. * Integrate pulling the supportedCountries data from the AppConfig for the submission transaction. (Previously wasn't implemented yet, now it's merged) * Address merge conflicts, and a little refactoring, and a bit more tests. * Revert file change to Project.xml * AppConfigProvider should insert "DE" as fallback if the supportedCountry list is empty/not supplied. * Don't insert the fallback country at application config provider level. The UI requires the list to be empty, if it is empty in the config. I've moved the fallback country insertion into the transaction. * Make detekt happy. * Make klint happy.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our appconfig handling should meet the desired specs analog to iOS.
Most of the resiliance features were already built in but we didn't fall back to the last valid config all cases, now we do.
How to test