This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix various code smells and refactor our Application class #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/util/WatchdogService.kt
Show resolved
Hide resolved
ralfgehrer
approved these changes
Sep 30, 2020
| @OnLifecycleEvent(Lifecycle.Event.ON_START) | ||
| fun onAppForegrounded() { | ||
| isAppInForeground = true | ||
| Timber.v("App is in the foreground") |
There was a problem hiding this comment.
Do we actually need these Timber logs? Same below.
There was a problem hiding this comment.
Was there before I refactored, but I also like it because it gives us more clues about what happened when the testers provide us with a log where there was an issue, we'll know whether the app was in the foreground or background etc. I'm usually a fan of extensive debug logging, huge gains when we encounter heisenbugs 😁.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix various code 👃 and refactor our Application class.
i.e. https://sonarcloud.io/project/issues?branch=fix%2Fflaky-downloader-test&id=corona-warn-app_cwa-app-android&resolved=false&types=CODE_SMELL
How to test