Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Better handling of unexpected supportedCountryData from the server (DEV) #1301

Merged
merged 3 commits into from
Oct 5, 2020
Merged

Better handling of unexpected supportedCountryData from the server (DEV) #1301

merged 3 commits into from
Oct 5, 2020

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented Oct 2, 2020 •
edited
Loading

Description

  • The PROD server returned isPlausibleDeniability for supportedCountries which caused the onboarding to crash when trying to map that to a string/drawable resource.
  • We removed country codes that were hardcoded in debug and deviceForTesters builds.
  • Now the AppConfigProvider will filter out single un-sane values, and the UI will map all country codes to known values and otherwise skip them.

How to test

  • Run the builds on different variants (especially deviceRelease with a self-made-keystore).

@d4rken
Better handling of unexpected supportedCountryData from the server.
5443c35 
Perform sanity checks on country data.
Map values to known `Country` enum.
@d4rken d4rken added bug Something isn't working maintainers Tag pull requests created by maintainers 1.5.0 labels Oct 2, 2020
@d4rken d4rken added this to the 1.5.0 milestone Oct 2, 2020
@d4rken d4rken requested a review from a team October 2, 2020 21:59
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

49.5% 49.5% Coverage
0.0% 0.0% Duplication

@harambasicluka harambasicluka changed the title Better handling of unexpected supportedCountryData from the server. Better handling of unexpected supportedCountryData from the server (DEV) Oct 5, 2020
@harambasicluka harambasicluka merged commit 1a08c25 into release/1.5.x Oct 5, 2020
@harambasicluka harambasicluka deleted the fix/deal_with_bad_appconfig_values branch October 5, 2020 06:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexanderAlferov AlexanderAlferov AlexanderAlferov approved these changes

@BMItr BMItr BMItr approved these changes

Assignees
No one assigned
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@d4rken @BMItr @AlexanderAlferov @harambasicluka