Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Add r8/proguard configuration to keep GSON related classes. #1348

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Add r8/proguard configuration to keep GSON related classes. #1348

merged 1 commit into from
Oct 7, 2020

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented Oct 7, 2020

Specifically keep data class members used in retrofit responses.

@d4rken
Add r8/proguard configuration to keep GSON related classes.
8788af8 
Specifically keep data class members used in retrofit responses.
@d4rken d4rken added bug Something isn't working maintainers Tag pull requests created by maintainers labels Oct 7, 2020
@d4rken d4rken added this to the 1.5.0 milestone Oct 7, 2020
@d4rken d4rken requested a review from a team October 7, 2020 14:06
ralfgehrer
ralfgehrer approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@d4rken
Copy link
Member Author

d4rken commented Oct 7, 2020

We specifically needed

-keepclassmembers,allowobfuscation class * {
  @com.google.gson.annotations.SerializedName <fields>;
}

I also added the rest of the recommended rules though.

@d4rken d4rken merged commit e17b605 into release/1.5.x Oct 7, 2020
@d4rken d4rken deleted the fix/r8-obfuscation branch October 7, 2020 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harambasicluka harambasicluka harambasicluka approved these changes

@ralfgehrer ralfgehrer ralfgehrer approved these changes

Assignees
No one assigned
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@d4rken @ralfgehrer @harambasicluka