Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Improving Sonarcloud Scans (EXPOSUREAPP-2772) #1359

Merged
merged 56 commits into from
Oct 9, 2020
Merged

Improving Sonarcloud Scans (EXPOSUREAPP-2772) #1359

merged 56 commits into from
Oct 9, 2020

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented Oct 8, 2020 •
edited
Loading

  • Moved duplicate command calls into custom commands to reduce duplicate code
  • Optimized call order of saving and restoring build and gradle caches
  • Moved sonarcloud into a sepperate job that depends deviceReleaseUnitTests
  • Reduce parallelism to 3 (from 4), currently the overhead from 4 offers no performance gain
  • Adjusted function names and descriptions
  • Removed jetitifier requirement to speed up compile times

@d4rken d4rken added the maintainers Tag pull requests created by maintainers label Oct 8, 2020
@d4rken d4rken changed the title Improving Sonarcloud Scans (DEV) Improving Sonarcloud Scans (EXPOSUREAPP-2772) Oct 8, 2020
d4rken added 21 commits October 8, 2020 17:56
@d4rken
Caches are still not being restored correctly, iterating.
97bd414
@d4rken
Caches are still not being restored correctly, iterating.
8bf586d
@d4rken
Caches are still not being restored correctly, iterating.
80751a2
@d4rken
Restore gradle caches for linting tasks too.
9dc17c4
@d4rken
Checkout needs to happen before cache check (checksum on gradle file)
9829b83
@d4rken
The android build cache is not the app one, but the .android one, res…
437a24d 
…tore that for all jobs.
@d4rken
Try to persist the whole project for jacoco
f75d971
@d4rken
Need the workspace before we can run the restore scripts which check …
6905b5c 
…the gradle file checksums.
@d4rken
Without cache reuse
4b9c91c
@d4rken
Setup single prepare project job.
460d6b6
@d4rken
Add missing prepare job
1210171
@d4rken
Make sure dot directories are passed into the workspace
423c54f
@d4rken
Iterate workspace matching.
366f3a9
@d4rken
Iterate workspace matching.
62bf3bc
@d4rken
Iterate workspace matching.
1fe955c
@d4rken
Adjust working directory.
3ba3a60
@d4rken
Don't use relative URL when attaching workspace.
e304939
@d4rken
Compile resources in prepare task.
fb304b3
@d4rken
Run the test task on machine.
2f51682
@d4rken
Run the test task on machine.
3bbe754
@d4rken
Run the test task on machine.
55678c9
@d4rken d4rken marked this pull request as ready for review October 9, 2020 08:47
@d4rken d4rken requested a review from a team October 9, 2020 08:47
harambasicluka
harambasicluka suggested changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the dependency changed in 1.6.0.

@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@d4rken d4rken merged commit 9b15733 into release/1.5.x Oct 9, 2020
@d4rken d4rken deleted the fix/circleci-sonarcloud branch October 9, 2020 09:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexanderAlferov AlexanderAlferov AlexanderAlferov approved these changes

@harambasicluka harambasicluka harambasicluka approved these changes

Assignees
No one assigned
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d4rken @harambasicluka @AlexanderAlferov