This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Fix LocalData - isInteroperabilityShownAtLeastOnce - set(value) to commit=true #1451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1421 (comment) and #1421 (comment)
Description
While discussing persistence using LocalData with @kolyaopahle , we found a small flaw in LocalData
cwa-app-android/Corona-Warn-App/src/main/java/de/rki/coronawarnapp/storage/LocalData.kt
Lines 717 to 733 in 0f12f4d
For
isInteroperabilityShownAtLeastOnce
thegetSharedPreferenceInstance().edit
lacksthe commit=true
. Would be nice to fix it for consistency of the code.@kolyaopahle kindly invited me to create a PR for this minor fix, but I must admit, I'd be proud like Oscar if it was to be merged.
Steps to reproduce
Investigate the code.