This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
Parse test JSON files and init unit tests with respective parameters (EXPOSUREAPP-3456) #1575
Merged
AlexanderAlferov
merged 101 commits into
feature/3456-enfv2-main-branch
from
feature/3517-parse-json
Nov 12, 2020
Merged
Parse test JSON files and init unit tests with respective parameters (EXPOSUREAPP-3456) #1575
AlexanderAlferov
merged 101 commits into
feature/3456-enfv2-main-branch
from
feature/3517-parse-json
Nov 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mappers responsible for creating the desired formats.
…e-updates-configs # Conflicts: # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/risklevel/ui/TestRiskLevelCalculationFragmentCWAViewModel.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/transaction/RiskLevelTransaction.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/transaction/RiskLevelTransactionTest.kt
…e-updates-configs # Conflicts: # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/risklevel/ui/TestRiskLevelCalculationFragmentCWAViewModel.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/transaction/RiskLevelTransaction.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/transaction/RiskLevelTransactionTest.kt
Provide the server time offset. Offer a lastUpdatedAt timestamp. Add an app config specific test screen. Clean up test screens a bit and move debug options out of API test options.
…e-updates-configs
Switch to config storage via json to be able to store additional meta data fields (i.e. time).
…e-updates-configs
…d its timestamps to determine an accurate time offset.
…e-updates-configs
…core-updates-configs' into feature/3455-more-frequent-riskscore-updates-configs
…ically triggers refreshes.
…nfv2' into feature/3537-enfv2-task-1
…Mapper for new config api (not yet introduced) Signed-off-by: Kolya Opahle <k.opahle@sap.com>
…into feature/3517-parse-json
…feature/3517-parse-json
…nfv2' into feature/3517-parse-json
…into feature/3517-parse-json # Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/risk/DefaultRiskLevels.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/risk/RiskLevels.kt
Signed-off-by: Kolya Opahle <k.opahle@sap.com>
AlexanderAlferov
added
enhancement
Improvement of an existing feature
maintainers
Tag pull requests created by maintainers
labels
Nov 11, 2020
AlexanderAlferov
requested review from
mlenkeit,
BMItr,
kolyaopahle,
chris-cwa and
a team
November 11, 2020 15:24
BMItr
approved these changes
Nov 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test cases are fine and behaving with expected result! good work 👍
left one comment..
...Warn-App/src/test/java/de/rki/coronawarnapp/nearby/windows/ExposureWindowsCalculationTest.kt
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created ExposureWindowsCalculationTest in de.rki.coronawarnapp.nearby.windows
Added multiple logs level for better debugging: right now only configuration and comparison table is shown:
private val logLevel = LogLevel.ONLY_COMPARISON
Test class contains only one test that should cover everything.