ENFClient v2 - ExposureDetectionTracker without identifier (EXPOSUREAPP-3540) #1605
Conversation
| exposureDetectionTracker.trackNewExposureDetection(token) | ||
| diagnosisKeyProvider.provideDiagnosisKeys(keyFiles, configuration, token) | ||
| } | ||
| // NO-OP |
There was a problem hiding this comment.
Maybe throw UnsupportedOperationException() until this is removed?
There was a problem hiding this comment.
throwing UnsupportedOperationException() now
| @@ -93,34 +94,16 @@ class DefaultExposureDetectionTracker @Inject constructor( | |||
| } | |||
| } | |||
|
|
|||
| override fun finishExposureDetection(identifier: String, result: Result) { | |||
| Timber.i("finishExposureDetection(token=%s, result=%s)", identifier, result) | |||
There was a problem hiding this comment.
Please re-add a log statement directly at function start, the following methods using updateSafely are async, if there is any issue there we'd still like to know that the function was called, but failed somewhere later.
| @@ -134,6 +117,54 @@ class DefaultExposureDetectionTracker @Inject constructor( | |||
| } | |||
| } | |||
|
|
|||
| private fun finishExposureDetectionWithoutIdentifier( | |||
There was a problem hiding this comment.
Would an extension function improve readability here?
Something like fun Map<String, TrackedExposureDetection>.findOrCreateByIdentifier(identifier: String?)
There was a problem hiding this comment.
I changed it to:
private fun Map<String, TrackedExposureDetection>.findUnfinishedOrCreateIdentifier(): String {
| .map { it.value } | ||
| .filter { it.finishedAt == null } | ||
| .maxByOrNull { it.startedAt.millis } | ||
| ?.identifier ?: kotlin.run { |
There was a problem hiding this comment.
A bit difficult to read. How could we make this easier on the 👀
There was a problem hiding this comment.
good point.
?.identifier ?: kotlin.run is out.
readability improved
|
Kudos, SonarCloud Quality Gate passed!
|
This PR implements one additional part of the new ExposureWindowMode (#1584 ).
We don't have a token anymore and can't provide one to the ExposureDetectionTracker.
This PR implements the opportunity to use ExposureDetectionTracker with & without identifier.
Note: ExposureDetectionTracker was CalculationTracker some days ago (just to prevent confusion).