Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fixed asset appconfig resolution for v2 config (EXPOSUREAPP-3456) #1654

Conversation

kolyaopahle
Copy link
Contributor

Description

This PR fixes a small issue with default app config resolution if no app config has ever been downloaded and no internet is available

@kolyaopahle kolyaopahle requested a review from a team November 18, 2020 14:26
@kolyaopahle kolyaopahle added backend Issues related to internal work not directly correlated to UI interaction maintainers Tag pull requests created by maintainers labels Nov 18, 2020
@kolyaopahle kolyaopahle added this to the 1.8.0 milestone Nov 18, 2020
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HUGE PR :-) Code LGTM, tested on Pixel 2 Device.

@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kolyaopahle kolyaopahle merged commit 940efa1 into feature/3456-enfv2-main-branch Nov 18, 2020
@kolyaopahle kolyaopahle deleted the fix/3456-wrong-default-appconfig-name branch November 18, 2020 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend Issues related to internal work not directly correlated to UI interaction maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants