This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Refactor ENF version check #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
still checking.. |
|
Sorry, let me know if you find a bug will create follow up PR. |
BMItr
reviewed
Nov 20, 2020
| } | ||
| // Check version of ENF, WindowMode since v1.5, but version check since v1.6 | ||
| // Will throw if requirement is not satisfied | ||
| enfVersion.requireMinimumVersion(ENFVersion.V1_6) |
There was a problem hiding this comment.
here I miss some kind of log before . (checking version... or something).
(no showstopper)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.