Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Privacy-Preserving Analytics Settings Polishing (DEV) #2322

Merged
merged 10 commits into from
Feb 11, 2021
Merged

Privacy-Preserving Analytics Settings Polishing (DEV) #2322

merged 10 commits into from
Feb 11, 2021

Conversation

axelherbstreith
Copy link
Contributor

@axelherbstreith axelherbstreith commented Feb 10, 2021 •
edited
Loading

This PR adapts some smaller thing in the privacy-preserving analytics UI.

Following is currently including:

  • Adaption of settings icons
  • Added link to ppa_more_information_fragment
  • Removed unused margin below the scroll view
  • Used predefined dimes for margins in the layouts
  • Aligned fonts of the bullet points in "Your Consent" container with the other parts of the fragment
  • Added clickListener to analytics row that contains the switch (not needed to directly click on the switch anymore)
  • Aligned font of the Privacy Declaration Box with other parts of the screen

@axelherbstreith axelherbstreith added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers labels Feb 10, 2021
@axelherbstreith axelherbstreith added this to the 1.13.0 milestone Feb 10, 2021
@axelherbstreith axelherbstreith marked this pull request as ready for review February 11, 2021 11:11
@axelherbstreith axelherbstreith requested a review from a team February 11, 2021 11:11
@axelherbstreith axelherbstreith changed the title Privacy-Preserving Analytics Polishing Privacy-Preserving Analytics Polishing (DEV) Feb 11, 2021
@axelherbstreith axelherbstreith changed the title Privacy-Preserving Analytics Polishing (DEV) Privacy-Preserving Analytics Settings Polishing (DEV) Feb 11, 2021
@harambasicluka harambasicluka self-assigned this Feb 11, 2021
harambasicluka
harambasicluka reviewed Feb 11, 2021
View reviewed changes
Copy link
Contributor

@harambasicluka harambasicluka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will test it on device now.

...ava/de/rki/coronawarnapp/ui/settings/analytics/SettingsPrivacyPreservingAnalyticsFragment.kt Outdated Show resolved Hide resolved
harambasicluka
harambasicluka approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice in dark and light mode!

  • Pixel 3

@sonarcloud
Copy link

sonarcloud bot commented Feb 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexanderAlferov AlexanderAlferov self-assigned this Feb 11, 2021
@axelherbstreith axelherbstreith merged commit 7d40940 into feature/4321-ppa-main Feb 11, 2021
@axelherbstreith axelherbstreith deleted the feature/4321-ppa-polishing branch February 11, 2021 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexanderAlferov AlexanderAlferov AlexanderAlferov approved these changes

@harambasicluka harambasicluka harambasicluka approved these changes

Assignees

@harambasicluka harambasicluka

@AlexanderAlferov AlexanderAlferov

Labels
maintainers Tag pull requests created by maintainers ui Issue related to UI aspects
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@axelherbstreith @harambasicluka @AlexanderAlferov