Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

QR Code scanning to check-in (EXPOSUREAPP-5305) #2507

Merged
merged 26 commits into from
Mar 4, 2021
Merged

QR Code scanning to check-in (EXPOSUREAPP-5305) #2507

merged 26 commits into from
Mar 4, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Mar 2, 2021 •
edited
Loading

  • Adds new scan fragment for Events - accessible from Test menu
  • Handle deep-linking from Google Lens or third party Scanner
  • Dummy confirmation screen
  • Unifies shortcuts and deeplinking handling in different cases such as:
    1- Shortcuts scenarios MUST function as before
    2- Opening a deep-link while user is not onboarded yet
    3- Opening a deep-link when user is onboarded
    4- Opening a deep-link when user is onboarded ,but delta onboarding should be shown
    5- Opening a deep-link when App is already open
    6- Shortcuts

Testing

  • Test shortcuts
  • Test App reset (Just it launches as before)
  • Scan Qr-Code attached
    • from Scan Fragment -> navigates to Confirmation screen
    • from Qr-code Scanner -> click on the link -> choose CWA to handle it -> navigates to Confirmation screen
      CoronaWarnApp-Event.pdf

@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label Mar 2, 2021
@mtwalli mtwalli added this to the 1.16.0 milestone Mar 2, 2021
@mtwalli mtwalli marked this pull request as ready for review March 2, 2021 17:50
@mtwalli mtwalli requested a review from a team March 2, 2021 17:50
mtwalli and others added 2 commits March 3, 2021 08:57
@mtwalli
Deep linking for Event Registration (EXPOSUREAPP-5305) (#2502)
bc2683e 
* Handle deep-linking and shortcuts

* lint

* Fillin intent in Onboarding

* Lint

* Delete ConfirmCheckInFragment.kt
@mtwalli
Fix test
cfa38e3
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

14.7% 14.7% Coverage
0.0% 0.0% Duplication

@LukasLechnerDev LukasLechnerDev self-assigned this Mar 4, 2021
LukasLechnerDev
LukasLechnerDev reviewed Mar 4, 2021
View reviewed changes
Corona-Warn-App/src/androidTest/java/de/rki/coronawarnapp/ui/launcher/LauncherActivityTest.kt
}

@Test
fun testDeepLinkLowercase() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you testing here? There is no assert? 🤔

Copy link
Contributor Author

@mtwalli mtwalli Mar 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing that the activity is launching when an intent with data=https://coronawarn.app/E1/SOME_PATH_GOES_HERE is fired

as you can see for cases below it will throw a RuntimeException to make sure those links are not handled by this activity

LukasLechnerDev
LukasLechnerDev approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on Samsung S20+ and Google Pixel 3A.

Shortcuts work as before.

Scanning the QR code from an external app also doesn't skip onboarding, if not yet done, and then navigates to the Confirmation Screen.

@AlexanderAlferov AlexanderAlferov self-assigned this Mar 4, 2021
AlexanderAlferov
AlexanderAlferov approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@AlexanderAlferov AlexanderAlferov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deeplinking works nice.
On Samsung S8 I had an issue with scanning QR code with built-in scanner: after scanning redirected to Galaxy Notes application, meanwhile other QR-code links works fine. After rebuilding QR code built-in scanner worked fine too. Probably some issues with test code.
With other QR-scanning apps no issues - everything works great 🚀

@mtwalli mtwalli merged commit 23498dd into feature/5062-event-registration-main Mar 4, 2021
@mtwalli mtwalli deleted the feature/5305-qrcode-scan-chenckin branch March 4, 2021 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LukasLechnerDev LukasLechnerDev LukasLechnerDev approved these changes

@AlexanderAlferov AlexanderAlferov AlexanderAlferov approved these changes

Assignees

@LukasLechnerDev LukasLechnerDev

@AlexanderAlferov AlexanderAlferov

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mtwalli @LukasLechnerDev @AlexanderAlferov