Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Event verification (EXPOSUREAPP-5423) #2524

Merged
merged 16 commits into from
Mar 10, 2021
Merged

Event verification (EXPOSUREAPP-5423) #2524

merged 16 commits into from
Mar 10, 2021
+220 −55

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Mar 4, 2021 •
edited
Loading

Please check specs: https://github.com/corona-warn-app/cwa-app-tech-spec/blob/proposal/event-registration-mvp/docs/spec/event-registration-client.md#attendee-check-in

  • Parse encoded trace location
  • Verify QRCode signature
  • Verify start and end times warning

Testing

  • Scan CoronaWarnApp-Event.pdf

  • An error message should appear , this event is signed with Key that is not part of testing environment configs

@mtwalli mtwalli requested a review from a team March 4, 2021 16:38
@mtwalli mtwalli marked this pull request as draft March 4, 2021 16:46
@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label Mar 4, 2021
@mtwalli mtwalli added this to the 1.16.0 milestone Mar 4, 2021
@mtwalli mtwalli changed the title Feature/5423 event verification Event verification (EXPOSUREAPP-5423) Mar 4, 2021
@d4rken
Copy link
Member

d4rken commented Mar 5, 2021

Depends on #2530

@mtwalli mtwalli marked this pull request as ready for review March 8, 2021 19:14
@LukasLechnerDev LukasLechnerDev self-assigned this Mar 9, 2021
@LukasLechnerDev
Copy link
Contributor

I get this crash when I scan the attached QR code via our TestMenu 👇

2021-03-09 11:51:57.598 9749-9749/de.rki.coronawarnapp.test E/AndroidRuntime: FATAL EXCEPTION: main
Process: de.rki.coronawarnapp.test, PID: 9749
java.lang.IllegalArgumentException: Navigation destination that matches request NavDeepLinkRequest{ uri=https://e.coronawarn.app/C1/BIYAUEDBZY6EIWF7QX6JOKSRPAGEB3H7CIIEGV2BEBGGC5LOMNUCAUDBOJ2HSGGTQ6SACIHXQ6SACKA6CJEDARQCEEAPHGEZ5JI2K2T422L5U3SMZY5DGCPUZ2RQACAYEJ3HQYMAFFBU2SQCEEAJAUCJSQJ7WDM675MCMOD3L2UL7ECJU7TYERH23B746RQTABO3CTI%3D } cannot be found in the navigation graph NavGraph(de.rki.coronawarnapp.test:id/nav_graph) startDestination={Destination(de.rki.coronawarnapp.test:id/mainFragment) label=HomeFragment class=de.rki.coronawarnapp.ui.main.home.HomeFragment}

@mtwalli
Copy link
Contributor Author

mtwalli commented Mar 9, 2021

I get this crash when I scan the attached QR code via our TestMenu 👇

2021-03-09 11:51:57.598 9749-9749/de.rki.coronawarnapp.test E/AndroidRuntime: FATAL EXCEPTION: main
Process: de.rki.coronawarnapp.test, PID: 9749
java.lang.IllegalArgumentException: Navigation destination that matches request NavDeepLinkRequest{ uri=https://e.coronawarn.app/C1/BIYAUEDBZY6EIWF7QX6JOKSRPAGEB3H7CIIEGV2BEBGGC5LOMNUCAUDBOJ2HSGGTQ6SACIHXQ6SACKA6CJEDARQCEEAPHGEZ5JI2K2T422L5U3SMZY5DGCPUZ2RQACAYEJ3HQYMAFFBU2SQCEEAJAUCJSQJ7WDM675MCMOD3L2UL7ECJU7TYERH23B746RQTABO3CTI%3D } cannot be found in the navigation graph NavGraph(de.rki.coronawarnapp.test:id/nav_graph) startDestination={Destination(de.rki.coronawarnapp.test:id/mainFragment) label=HomeFragment class=de.rki.coronawarnapp.ui.main.home.HomeFragment}

Sorry my bad, I attached a new PDF. the other one is using new host

@d4rken d4rken self-requested a review March 10, 2021 12:35
@d4rken d4rken self-assigned this Mar 10, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

6.7% 6.7% Coverage
0.0% 0.0% Duplication

d4rken
d4rken approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

...in/java/de/rki/coronawarnapp/eventregistration/checkins/qrcode/InvalidQRCodeDataException.kt
@@ -0,0 +1,6 @@
package de.rki.coronawarnapp.eventregistration.checkins.qrcode

class InvalidQRCodeDataException constructor(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we later need to display errors to the user, these can then implement the HasHumanReadableError interface 👍

LukasLechnerDev
LukasLechnerDev approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Scanning the QR code shows the correct error message.

@mtwalli mtwalli merged commit e9e7635 into feature/5062-event-registration-main Mar 10, 2021
@mtwalli mtwalli deleted the feature/5423-event-verification branch March 10, 2021 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d4rken d4rken d4rken approved these changes

@LukasLechnerDev LukasLechnerDev LukasLechnerDev approved these changes

Assignees

@d4rken d4rken

@LukasLechnerDev LukasLechnerDev

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mtwalli @d4rken @LukasLechnerDev