Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Create Check-in confirmation screen (EXPOSUREAPP-5424) #2536

Merged

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Mar 5, 2021

  • Move screens under ui.eventregistration.attendee package
  • Create two navigation graphs for attendee and organizer
  • Add tab item for checkins and empty screen for it
  • Handle deep-linking in Check-Ins fragment
  • Validate deeplink uri

Testing

Invalid.pdf
Valid.pdf

  • Scan QR Code from CWA scan screen or using third party scanner
  • For valid QRCode:
    • A third party App will trigger CWA and opens Confirmation screen
    • Scan screen will open Confirmation screen
  • For Invalid QRCode:
    • A third party App will NOT trigger CWA -> browser will open this link
    • Scan screen will open an error dialog

Update

After merging Verification PR , scanning Valid qr-code PDF will show an error too, since it is signed by a public that does not exist in any of our testing env

mtwalli added 6 commits March 4, 2021 22:10
- Add basic setup for attendee and organizer
- Renaming and re-packing for already implemented screens
@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label Mar 5, 2021
@mtwalli mtwalli added this to the 1.16.0 milestone Mar 5, 2021
@mtwalli mtwalli requested review from a team March 5, 2021 15:32
@mtwalli mtwalli added the text change PRs with text changes. label Mar 8, 2021
@AlexanderAlferov AlexanderAlferov self-assigned this Mar 9, 2021
Copy link
Contributor

@AlexanderAlferov AlexanderAlferov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on S8. Everything looks good.
Still have issues with navigation from built-in application on Samsung S8, but this is probably test pdf issue.

@mtwalli
Copy link
Contributor Author

mtwalli commented Mar 9, 2021

Tested on S8. Everything looks good.
Still have issues with navigation from built-in application on Samsung S8, but this is probably test pdf issue.

Thanks @AlexanderAlferov for the feedback. I think I know where the issue is.
Camera Samsung App is triggering intent:

            <intent-filter>
                <action android:name="android.intent.action.SEND" />
                <category android:name="android.intent.category.DEFAULT" />
                <data
                    android:mimeType="text/plain" />
            </intent-filter>

while the App should respond to :

           <intent-filter>
                <action android:name="android.intent.action.VIEW" />

                <category android:name="android.intent.category.DEFAULT" />
                <category android:name="android.intent.category.BROWSABLE" />

                <data
                    android:host="e.coronawarn.app"
                    android:pathPrefix="/"
                    android:scheme="https" />
            </intent-filter>

According to Android docs :https://developer.android.com/training/app-links/deep-linking
the intent action should be VIEW not SEND

I noticed also that Chrome is NOT showing up in the sharing menu options .
I can add, but this will make CWA respond to sharing messages too like WhatsApp 😄

@chiljamgossow chiljamgossow self-assigned this Mar 10, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

13.8% 13.8% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit b861799 into feature/5062-event-registration-main Mar 11, 2021
@mtwalli mtwalli deleted the feature/5424-checkin-screen branch March 11, 2021 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants