Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Derive check-ins time (EXPOSUREAPP-5708) #2623

Merged
merged 24 commits into from
Mar 17, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Mar 15, 2021

  • Derive time for check-ins start and end time
  • Add scenarios
  • Not used anywhere yet

Requires changes in #2611, review it first

@mtwalli mtwalli added the maintainers Tag pull requests created by maintainers label Mar 15, 2021
@mtwalli mtwalli added this to the 2.0.0 milestone Mar 15, 2021
@mtwalli mtwalli requested a review from a team March 15, 2021 15:42
@d4rken d4rken self-requested a review March 16, 2021 10:34
@d4rken d4rken self-assigned this Mar 16, 2021
d4rken
d4rken previously approved these changes Mar 16, 2021
Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

d4rken
d4rken previously approved these changes Mar 16, 2021
@ralfgehrer ralfgehrer self-assigned this Mar 17, 2021
ralfgehrer
ralfgehrer previously approved these changes Mar 17, 2021
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. LGTM

@mtwalli mtwalli dismissed stale reviews from ralfgehrer and d4rken via 9084884 March 17, 2021 14:27
@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.1% 98.1% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit 2fee6d3 into release/2.0.x Mar 17, 2021
@mtwalli mtwalli deleted the feature/5708-derive-check-ins-time branch March 17, 2021 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants