This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 492
Event registration - create event homescreen tile (EXPOSUREAPP-5411) #2636
Merged
harambasicluka
merged 13 commits into
release/2.0.x
from
feature/5411-create-event-tile
Mar 22, 2021
Merged
Event registration - create event homescreen tile (EXPOSUREAPP-5411) #2636
harambasicluka
merged 13 commits into
release/2.0.x
from
feature/5411-create-event-tile
Mar 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SamuraiKek
commented
Mar 17, 2021
- Adds the create event tile on the homescreen for the organizer flow.
- Navigation from the tile will be added in a later PR.
- Strings are temporary
# Conflicts: # Corona-Warn-App/src/main/res/values-de/event_registration_strings.xml # Corona-Warn-App/src/main/res/values/event_registration_strings.xml
mtwalli
reviewed
Mar 18, 2021
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeAdapter.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/values-de/event_registration_strings.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/values-de/event_registration_strings.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/values-de/event_registration_strings.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/values/event_registration_strings.xml
Outdated
Show resolved
Hide resolved
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeFragmentViewModel.kt
Corona-Warn-App/src/main/res/values-de/event_registration_strings.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/values/event_registration_strings.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukas Lechner <lukas.lechner@sap.com>
LukasLechnerDev
approved these changes
Mar 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 Thanks for the wording change!
mtwalli
approved these changes
Mar 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! Tested on Samsung S8
Kudos, SonarCloud Quality Gate passed! |
janetback
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UA reviewed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.