This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
CheckIn cards & interaction (EXPOSUREAPP-5410) #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4rken
added
enhancement
AlexanderAlferov
approved these changes
Mar 18, 2021
|
Kudos, SonarCloud Quality Gate passed! |
ralfgehrer
reviewed
Mar 19, 2021
| val confirmationEvent = SingleLiveEvent<TraceLocationVerifyResult>() | ||
|
|
||
| val checkins = FAKE_CHECKIN_SOURCE | ||
| .map { checkins -> checkins.sortedBy { it.checkInEnd } } |
There was a problem hiding this comment.
Do we need 2nd level sort order - e.g. checkInStart - to have a stable sorting for active events?
There was a problem hiding this comment.
Good point, by title would make sense, will add in follow up PRs.
|
It seems that the padding of the floating button on the right side slightly too big.
|
ralfgehrer
approved these changes
Mar 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add:
The list displays dummy data and the menus/clicks don't do anything yet, this will come in a different PR.
The card for old check-ins currently says
21.01.2021, 18:01 - 18:26, without theUhr, I will add this in a different PR after it is clear how we handle check-ins spanning multiple days.