This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Add tracelocation byterepresentation to TraceLocation database table (DEV) #2647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epresentation # Conflicts: # Corona-Warn-App/schemas/de.rki.coronawarnapp.eventregistration.storage.TraceLocationDatabase/1.json
LukasLechnerDev
force-pushed
the
feature/DEV-Add-tracelocation-byterepresentation
branch
from
b3b60f7 to
fda4cba
Compare
LukasLechnerDev
changed the title
d4rken
reviewed
Mar 22, 2021
| @@ -18,8 +18,8 @@ data class TraceLocationEntity( | |||
| @ColumnInfo(name = "startDate") val startDate: Instant?, | |||
| @ColumnInfo(name = "endDate") val endDate: Instant?, | |||
| @ColumnInfo(name = "defaultCheckInLengthInMinutes") val defaultCheckInLengthInMinutes: Int?, | |||
| @ColumnInfo(name = "byteRepresentation") val byteRepresentationBase64: String, | |||
There was a problem hiding this comment.
Should the columnName then also be byteRepresentationBase64 ?
There was a problem hiding this comment.
Yes makes sense. However we are also not suffixing the base64 encoded values in the CheckInEntity. I think a PR in which we refactor the 2 entities would be best. I can do this after this one is merged, if that's fine for you?
chiljamgossow
approved these changes
Mar 22, 2021
|
Kudos, SonarCloud Quality Gate passed! |
d4rken
approved these changes
Mar 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TechSpec says to store the byte representation of the TraceLocation into the TraceLocation database table.
This PR does exactly that.
We decided to store the byte representation as base64 encoded string in the database.