This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Add comment to prevent accidentally breaking the fix for EXPOSUREAPP-4484 (DEV) #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasLechnerDev
approved these changes
Mar 19, 2021
chris-cwa
approved these changes
Mar 19, 2021
Comment on lines
+129
to
+135
| // START - Fix for EXPOSUREAPP-4484 relies on this call order | ||
| submissionSettings.registrationToken.update { | ||
| registrationData.registrationToken | ||
| } | ||
| updateTestResult(registrationData.testResult) | ||
| submissionSettings.devicePairingSuccessfulAt = timeStamper.nowUTC | ||
| // END |
There was a problem hiding this comment.
Suggested change
| // START - Fix for EXPOSUREAPP-4484 relies on this call order | |
| submissionSettings.registrationToken.update { | |
| registrationData.registrationToken | |
| } | |
| updateTestResult(registrationData.testResult) | |
| submissionSettings.devicePairingSuccessfulAt = timeStamper.nowUTC | |
| // END | |
| // region Fix for EXPOSUREAPP-4484 relies on this call order | |
| submissionSettings.registrationToken.update { | |
| registrationData.registrationToken | |
| } | |
| updateTestResult(registrationData.testResult) | |
| submissionSettings.devicePairingSuccessfulAt = timeStamper.nowUTC | |
| // endregion |
Comment on lines
+144
to
+150
| // START - Fix for EXPOSUREAPP-4484 relies on this call order | ||
| submissionSettings.registrationToken.update { | ||
| registrationData.registrationToken | ||
| } | ||
| updateTestResult(registrationData.testResult) | ||
| submissionSettings.devicePairingSuccessfulAt = timeStamper.nowUTC | ||
| // END |
There was a problem hiding this comment.
Suggested change
| // START - Fix for EXPOSUREAPP-4484 relies on this call order | |
| submissionSettings.registrationToken.update { | |
| registrationData.registrationToken | |
| } | |
| updateTestResult(registrationData.testResult) | |
| submissionSettings.devicePairingSuccessfulAt = timeStamper.nowUTC | |
| // END | |
| // region Fix for EXPOSUREAPP-4484 relies on this call order | |
| submissionSettings.registrationToken.update { | |
| registrationData.registrationToken | |
| } | |
| updateTestResult(registrationData.testResult) | |
| submissionSettings.devicePairingSuccessfulAt = timeStamper.nowUTC | |
| // endregion |
|
you could also extract the calls into a method and then unit test, that calls are made in this order. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.