Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Adjust margins for lists with card like items (DEV) #2650

Merged
merged 5 commits into from
Mar 22, 2021

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented Mar 19, 2021

Follow up PR to our previous UX/UI meeting.

We have lists of cards in 3 places, the margins on each where different.

  • HomeFragment: 16,16,16,16
  • DiaryOverview: 24,8,24,8
  • DiaryPerson/Location: 24,16,24,16
  • CheckIns: 24,16,24,16

I've adjusted the margin to match the home fragment, so when moving from home fragment to diary/checkins the transitions looks nicer because the card sizes match. We also get more estate for texts and titles, which were a bit crunched.

@d4rken d4rken added the maintainers Tag pull requests created by maintainers label Mar 19, 2021
@d4rken d4rken added this to the 2.0.0 milestone Mar 19, 2021
@d4rken d4rken requested a review from a team March 19, 2021 11:20
@d4rken d4rken changed the title Adjust margins for lists with card like items Adjust margins for lists with card like items (DEV) Mar 19, 2021
@d4rken
Copy link
Member Author

d4rken commented Mar 19, 2021

Screenshot from 2021-03-19 12-23-32
Screenshot from 2021-03-19 12-23-24
Screenshot from 2021-03-19 12-23-17
Screenshot from 2021-03-19 12-23-11
Screenshot from 2021-03-19 12-23-01

@harambasicluka harambasicluka self-assigned this Mar 19, 2021
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested on a OnePlus 8.

Is there a reason why you only considered this for lists? E.g. Contact Diary -> Add place: the input field or also indented. Could be part of another refactoring round.

@chiljamgossow chiljamgossow self-assigned this Mar 22, 2021
@d4rken
Copy link
Member Author

d4rken commented Mar 22, 2021

Is there a reason why you only considered this for lists? E.g. Contact Diary -> Add place: the input field or also indented. Could be part of another refactoring round.

Only the lists came up so far, when I find time, I can check the other margings too, but AFAICT, the add person/location margin is correct at 24dp.

@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@d4rken d4rken merged commit 04896ba into release/2.0.x Mar 22, 2021
@d4rken d4rken deleted the fix/DEV-adjust-list-margins branch March 22, 2021 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants