This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Daily deletion of stale trace locations and CheckIns (EXPOSUREAPP-5748, EXPOSUREAPP-5764) #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TraceLocations-and-CheckIns
…TraceLocations-and-CheckIns
…TraceLocations-and-CheckIns
…TraceLocations-and-CheckIns
…TraceLocations-and-CheckIns
LukasLechnerDev
changed the title
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/CoronaWarnApplication.kt
Outdated
Show resolved
Hide resolved
...App/src/main/java/de/rki/coronawarnapp/eventregistration/storage/retention/CheckInCleaner.kt
Outdated
Show resolved
Hide resolved
...oronawarnapp/eventregistration/storage/retention/EventRegistrationDbCleanUpPeriodicWorker.kt
Outdated
Show resolved
Hide resolved
mtwalli
reviewed
Mar 29, 2021
...App/src/main/java/de/rki/coronawarnapp/eventregistration/storage/retention/CheckInCleaner.kt
Outdated
Show resolved
Hide resolved
...c/main/java/de/rki/coronawarnapp/eventregistration/storage/retention/TraceLocationCleaner.kt
Outdated
Show resolved
Hide resolved
...c/main/java/de/rki/coronawarnapp/eventregistration/storage/retention/TraceLocationCleaner.kt
Show resolved
Hide resolved
.../de/rki/coronawarnapp/eventregistration/storage/retention/TraceLocationDbCleanUpScheduler.kt
Outdated
Show resolved
Hide resolved
...App/src/main/java/de/rki/coronawarnapp/eventregistration/storage/retention/CheckInCleaner.kt
Show resolved
Hide resolved
...ki/coronawarnapp/eventregistration/storage/retention/TraceLocationDbCleanUpPeriodicWorker.kt
Outdated
Show resolved
Hide resolved
…TraceLocations-and-CheckIns
…TraceLocations-and-CheckIns
…TraceLocations-and-CheckIns
…TraceLocations-and-CheckIns
…TraceLocations-and-CheckIns
chiljamgossow
approved these changes
Mar 30, 2021
…TraceLocations-and-CheckIns
|
Kudos, SonarCloud Quality Gate passed! |
LukasLechnerDev
deleted the
feature/5748-Automatic-Deletion-of-TraceLocations-and-CheckIns
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts a periodic worker (runs daily) at app start that deletes all
TraceLocationsandCheckInsin the database that have an endDate that is older than 15 days.The approach here is different than the deletion of Items in the Contact Journal.
In the Contact Journal:
We decided not to delete trace locations and check-ins whenever the user enters the corresponding screen, as we then would need to wait until the deletion is completed before we can show the items to the user, which makes the code more complex and harms the performance. Instead, the TraceLocation/CheckIn Screen needs to filter the
TraceLocations/CheckInsfrom the repository and only show ones with an endDate < 15 days. This will be done in another PR.