This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Organizer QrCode Screen (EXPOSUREAPP-5831) #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelherbstreith
added
ui
…anizer-qr-code-screen
…anizer-qr-code-screen
…anizer-qr-code-screen
mtwalli
reviewed
Mar 22, 2021
Corona-Warn-App/src/deviceForTesters/res/navigation/test_nav_graph.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/trace_location_organizer_qr_code_detail_fragment.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/trace_location_organizer_qr_code_detail_fragment.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/trace_location_organizer_qr_code_detail_fragment.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/trace_location_organizer_qr_code_detail_fragment.xml
Outdated
Show resolved
Hide resolved
...in/java/de/rki/coronawarnapp/ui/eventregistration/organizer/details/QrCodeDetailViewModel.kt
Outdated
Show resolved
Hide resolved
...in/java/de/rki/coronawarnapp/ui/eventregistration/organizer/details/QrCodeDetailViewModel.kt
Outdated
Show resolved
Hide resolved
.../main/java/de/rki/coronawarnapp/ui/eventregistration/organizer/details/QrCodeDetailModule.kt
Outdated
Show resolved
Hide resolved
...ain/java/de/rki/coronawarnapp/ui/eventregistration/organizer/details/QrCodeDetailFragment.kt
Outdated
Show resolved
Hide resolved
...ain/java/de/rki/coronawarnapp/ui/eventregistration/organizer/details/QrCodeDetailFragment.kt
Show resolved
Hide resolved
|
Xiamoi Mi 9, Android 9 The gradient and the snappiness are working create!!! 🚀 I only found two minor things. All corners are rounded, something light blue is shining through: There is to much spacing between the Qr code and date/time, try it with 24dp: |
…anizer-qr-code-screen
…anizer-qr-code-screen
axelherbstreith
changed the title
…anizer-qr-code-screen
…anizer-qr-code-screen
mtwalli
previously approved these changes
Mar 26, 2021
harambasicluka
suggested changes
Mar 26, 2021
Corona-Warn-App/src/main/res/layout/trace_location_organizer_qr_code_detail_fragment.xml
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/res/layout/trace_location_organizer_qr_code_detail_fragment.xml
Outdated
Show resolved
Hide resolved
...ain/java/de/rki/coronawarnapp/ui/eventregistration/organizer/details/QrCodeDetailFragment.kt
Outdated
Show resolved
Hide resolved
...in/java/de/rki/coronawarnapp/ui/eventregistration/organizer/details/QrCodeDetailViewModel.kt
Outdated
Show resolved
Hide resolved
...in/java/de/rki/coronawarnapp/ui/eventregistration/organizer/details/QrCodeDetailViewModel.kt
Outdated
Show resolved
Hide resolved
LukasLechnerDev
approved these changes
Mar 26, 2021
mtwalli
approved these changes
Mar 26, 2021
mtwalli
reviewed
Mar 26, 2021
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content"> | ||
|
|
||
| <ImageView |
There was a problem hiding this comment.
I think you can use com.google.android.material.imageview.ShapeableImageView to make it rounded as Luka suggested
…anizer-qr-code-screen
…anizer-qr-code-screen
…anizer-qr-code-screen
|
Kudos, SonarCloud Quality Gate passed! |
harambasicluka
approved these changes
Mar 29, 2021
harambasicluka
deleted the
feature/5831-event-registration-organizer-qr-code-screen
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test the PR: Go to "Test Menu" -> "Event Registration" -> "Open Organizer Fragment"
Design