Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix ripple effect for i button in circumstances text field (COMMUNITY) (#2701, EXPOSUREAPP-6002) #2702

Conversation

fynngodau
Copy link
Contributor

@fynngodau fynngodau commented Mar 28, 2021

This PR addresses the problem described in #2701.

Additionally, I removed some padding to the end (right) of the button because that felt better to me. If you don't like that I can modify the PR to add the removed padding again.

state before after
idle Screenshot_1616950651 Screenshot_1616950790
ripple shown (holding) ripple shown before Screenshot_1616950827

Internal Tracking ID: EXPOSUREAPP-6002

@fynngodau fynngodau requested a review from a team March 28, 2021 17:09
@dsarkar dsarkar added community Tag issues created by community members UX Issue related to UX aspects mirrored-to-jira This item is also tracked internally in JIRA labels Mar 28, 2021
@fynngodau fynngodau changed the title Fix ripple effect for i button in circumstances text field (COMMUNITY) (#2701) Fix ripple effect for i button in circumstances text field (COMMUNITY) (#2701, EXPOSUREAPP-6002) Mar 28, 2021
@harambasicluka
Copy link
Contributor

@fynngodau we are currently completely focusing on the event registration. We'll try to merge your PR at the end :) Thank's for your patients!

@fynngodau
Copy link
Contributor Author

@harambasicluka No worries, I saw that you all are being very focused at the moment – and the 2.0 event registration features are coming together really well, you can do it! Best of luck 😊

@fynngodau fynngodau changed the base branch from release/2.0.x to release/2.1.x April 19, 2021 17:20
@BMItr BMItr self-assigned this Apr 28, 2021
Copy link
Contributor

@BMItr BMItr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on oneplus 8.
Ripple effect is better now 👌
I think there are other elements than 'space' especially for constraint layouts. but it won't hurt

@harambasicluka harambasicluka merged commit 64b0ce7 into corona-warn-app:release/2.1.x Apr 28, 2021
@fynngodau fynngodau deleted the fix/circumstances-ripple branch July 28, 2021 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community Tag issues created by community members mirrored-to-jira This item is also tracked internally in JIRA UX Issue related to UX aspects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants