This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 493
Fix ripple effect for i button in circumstances text field (COMMUNITY) (#2701, EXPOSUREAPP-6002) #2702
Merged
harambasicluka
merged 7 commits into
corona-warn-app:release/2.1.x
from
fynngodau:fix/circumstances-ripple
Apr 28, 2021
Merged
Fix ripple effect for i button in circumstances text field (COMMUNITY) (#2701, EXPOSUREAPP-6002) #2702
harambasicluka
merged 7 commits into
corona-warn-app:release/2.1.x
from
fynngodau:fix/circumstances-ripple
Apr 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsarkar
added
community
Tag issues created by community members
UX
Issue related to UX aspects
mirrored-to-jira
This item is also tracked internally in JIRA
labels
Mar 28, 2021
fynngodau
changed the title
Fix ripple effect for i button in circumstances text field (COMMUNITY) (#2701)
Fix ripple effect for i button in circumstances text field (COMMUNITY) (#2701, EXPOSUREAPP-6002)
Mar 28, 2021
@fynngodau we are currently completely focusing on the event registration. We'll try to merge your PR at the end :) Thank's for your patients! |
@harambasicluka No worries, I saw that you all are being very focused at the moment – and the 2.0 event registration features are coming together really well, you can do it! Best of luck 😊 |
harambasicluka
approved these changes
Apr 26, 2021
BMItr
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on oneplus 8.
Ripple effect is better now 👌
I think there are other elements than 'space' especially for constraint layouts. but it won't hurt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
community
Tag issues created by community members
mirrored-to-jira
This item is also tracked internally in JIRA
UX
Issue related to UX aspects
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the problem described in #2701.
Additionally, I removed some padding to the end (right) of the button because that felt better to me. If you don't like that I can modify the PR to add the removed padding again.
Internal Tracking ID: EXPOSUREAPP-6002