This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
Trace Location QR Info screen (EXPOSUREAPP-5411) #2708
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuraiKek
added
maintainers
Tag pull requests created by maintainers
text change
PRs with text changes.
labels
Mar 29, 2021
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/eventregistration/EventRegistrationUIModule.kt
janetback
reviewed
Mar 30, 2021
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeFragmentViewModel.kt
Outdated
Show resolved
Hide resolved
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeFragmentViewModel.kt
Outdated
Show resolved
Hide resolved
janetback
previously approved these changes
Mar 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UA reviewed.
...na-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/items/CreateTraceLocationCard.kt
Outdated
Show resolved
Hide resolved
ralfgehrer
reviewed
Mar 30, 2021
...va/de/rki/coronawarnapp/ui/eventregistration/organizer/qrinfo/TraceLocationQRInfoFragment.kt
Outdated
Show resolved
Hide resolved
ralfgehrer
reviewed
Mar 30, 2021
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeFragment.kt
Outdated
Show resolved
Hide resolved
ralfgehrer
reviewed
Mar 30, 2021
axelherbstreith
suggested changes
Mar 31, 2021
Corona-Warn-App/src/main/res/layout/trace_location_organizer_qr_code_info_fragment.xml
Outdated
Show resolved
Hide resolved
SamuraiKek
requested review from
ralfgehrer,
axelherbstreith,
jurajkusnier and
janetback
March 31, 2021 09:39
ralfgehrer
reviewed
Mar 31, 2021
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/main/home/HomeFragment.kt
Outdated
Show resolved
Hide resolved
ralfgehrer
approved these changes
Mar 31, 2021
ralfgehrer
previously approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested on Pixel (Android 10)
# Conflicts: # Corona-Warn-App/src/main/res/values/event_registration_strings.xml
ralfgehrer
changed the title
Trace Location QR Info screen
Trace Location QR Info screen (EXPOSUREAPP-5411)
Mar 31, 2021
ralfgehrer
approved these changes
Mar 31, 2021
jurajkusnier
approved these changes
Mar 31, 2021
janetback
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UA reviewed.
Kudos, SonarCloud Quality Gate passed! |
axelherbstreith
approved these changes
Mar 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the QR info screen to the Trace Location Organizer flow. The screen is not shown after the user presses the acknowledge button.