Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Trace Location QR Info screen (EXPOSUREAPP-5411) #2708

Merged
merged 22 commits into from
Mar 31, 2021

Conversation

SamuraiKek
Copy link
Contributor

Adds the QR info screen to the Trace Location Organizer flow. The screen is not shown after the user presses the acknowledge button.

@SamuraiKek SamuraiKek added maintainers Tag pull requests created by maintainers text change PRs with text changes. labels Mar 29, 2021
@SamuraiKek SamuraiKek added this to the 2.0.0 milestone Mar 29, 2021
@SamuraiKek SamuraiKek requested review from a team March 29, 2021 14:09
# Conflicts:
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/eventregistration/EventRegistrationUIModule.kt
@ralfgehrer ralfgehrer self-assigned this Mar 30, 2021
@jurajkusnier jurajkusnier self-assigned this Mar 30, 2021
@jurajkusnier jurajkusnier self-requested a review March 30, 2021 09:06
janetback
janetback previously approved these changes Mar 30, 2021
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed.

@jurajkusnier
Copy link
Contributor

image

The text doesn't fit the screen.

ralfgehrer
ralfgehrer previously approved these changes Mar 31, 2021
Copy link
Contributor

@ralfgehrer ralfgehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on Pixel (Android 10)

# Conflicts:
#	Corona-Warn-App/src/main/res/values/event_registration_strings.xml
@ralfgehrer ralfgehrer changed the title Trace Location QR Info screen Trace Location QR Info screen (EXPOSUREAPP-5411) Mar 31, 2021
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed.

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

3.1% 3.1% Coverage
0.0% 0.0% Duplication

@SamuraiKek SamuraiKek merged commit 60488d7 into release/2.0.x Mar 31, 2021
@SamuraiKek SamuraiKek deleted the feature/5411-qr-codes-info-screen branch March 31, 2021 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants