Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Basic poster template download and caching (EXPOSUREAPP-5842) #2709

Merged

Conversation

LukasLechnerDev
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev commented Mar 29, 2021

Implements basic poster template download and caching.

Details can be found in the first part of Point 1 from TechSpec Poster Generation.

Not included

  • In case we receive an invalid network response or the user is offline, we should return the most recent cached or the default poster. This will be implemented in SubTask EXPOSUREAPP-6079.

How to Test

  • Download latest test_environment.json from wiki that includes QRCODE_POSTER_TEMPLATE_URL
  • Start MockServer
  • TestMenu => EventReg => QR Code and Poster Generation
  • Click "Download Poster Template" Button
  • The result is shown below the QR code

@LukasLechnerDev LukasLechnerDev changed the title Basic poster template download and storage (EXPOSUREAPP-5842) Basic poster template download and caching (EXPOSUREAPP-5842) Mar 29, 2021
@LukasLechnerDev LukasLechnerDev marked this pull request as ready for review March 29, 2021 16:05
@LukasLechnerDev LukasLechnerDev requested a review from a team March 29, 2021 16:05
@harambasicluka harambasicluka added the maintainers Tag pull requests created by maintainers label Mar 29, 2021
@harambasicluka harambasicluka added this to the 2.0.0 milestone Mar 29, 2021
mtwalli
mtwalli previously approved these changes Mar 30, 2021
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtwalli mtwalli self-assigned this Mar 30, 2021
@mtwalli mtwalli added the prio PRs to review first. label Mar 31, 2021
mtwalli
mtwalli previously approved these changes Mar 31, 2021
@jurajkusnier jurajkusnier self-assigned this Mar 31, 2021
jurajkusnier
jurajkusnier previously approved these changes Mar 31, 2021
…ad-and-storage

# Conflicts:
#	Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/debugoptions/ui/DebugOptionsFragment.kt
#	Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/debugoptions/ui/EnvironmentState.kt
#	Corona-Warn-App/src/deviceForTesters/res/layout/fragment_test_debugoptions.xml
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/environment/EnvironmentSetup.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/environment/eventregistration/createtracelocation/CreateTraceLocationCDNServerUrl.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/environment/eventregistration/createtracelocation/CreateTraceLocationModule.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/environment/eventregistration/createtracelocation/TraceLocationCDNHttpClient.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/EventRegistrationModule.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/events/TraceLocationCreator.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/events/server/createtracelocation/CreateTraceLocationApiV1.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/events/server/createtracelocation/TraceLocationServer.kt
#	Corona-Warn-App/src/test/java/de/rki/coronawarnapp/environment/EnvironmentSetupTest.kt
#	Corona-Warn-App/src/test/java/de/rki/coronawarnapp/eventregistration/events/TraceLocationCreatorTest.kt
#	Corona-Warn-App/src/test/java/de/rki/coronawarnapp/eventregistration/events/server/TraceLocationServerTest.kt
#	Corona-Warn-App/src/testDeviceForTesters/java/de/rki/coronawarnapp/test/debugoptions/ui/DebugOptionsFragmentViewModelTest.kt
@LukasLechnerDev LukasLechnerDev dismissed stale reviews from jurajkusnier and mtwalli via 195b6fd March 31, 2021 15:57
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

79.2% 79.2% Coverage
0.0% 0.0% Duplication

@LukasLechnerDev LukasLechnerDev merged commit b1220b1 into release/2.0.x Mar 31, 2021
@LukasLechnerDev LukasLechnerDev deleted the feature/5842-Poster-template-download-and-storage branch March 31, 2021 16:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants