This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
Basic poster template download and caching (EXPOSUREAPP-5842) #2709
Merged
LukasLechnerDev
merged 23 commits into
release/2.0.x
from
feature/5842-Poster-template-download-and-storage
Mar 31, 2021
Merged
Basic poster template download and caching (EXPOSUREAPP-5842) #2709
LukasLechnerDev
merged 23 commits into
release/2.0.x
from
feature/5842-Poster-template-download-and-storage
Mar 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad-and-storage # Conflicts: # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/eventregistration/ui/qrcode/QrCodeCreationTestViewModel.kt
LukasLechnerDev
changed the title
Basic poster template download and storage (EXPOSUREAPP-5842)
Basic poster template download and caching (EXPOSUREAPP-5842)
Mar 29, 2021
mtwalli
reviewed
Mar 30, 2021
...nawarnapp/eventregistration/events/server/qrcodepostertemplate/QrCodePosterTemplateServer.kt
Outdated
Show resolved
Hide resolved
mtwalli
previously approved these changes
Mar 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mtwalli
previously approved these changes
Mar 31, 2021
jurajkusnier
previously approved these changes
Mar 31, 2021
…ad-and-storage # Conflicts: # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/debugoptions/ui/DebugOptionsFragment.kt # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/debugoptions/ui/EnvironmentState.kt # Corona-Warn-App/src/deviceForTesters/res/layout/fragment_test_debugoptions.xml # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/environment/EnvironmentSetup.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/environment/eventregistration/createtracelocation/CreateTraceLocationCDNServerUrl.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/environment/eventregistration/createtracelocation/CreateTraceLocationModule.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/environment/eventregistration/createtracelocation/TraceLocationCDNHttpClient.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/EventRegistrationModule.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/events/TraceLocationCreator.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/events/server/createtracelocation/CreateTraceLocationApiV1.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/events/server/createtracelocation/TraceLocationServer.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/environment/EnvironmentSetupTest.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/eventregistration/events/TraceLocationCreatorTest.kt # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/eventregistration/events/server/TraceLocationServerTest.kt # Corona-Warn-App/src/testDeviceForTesters/java/de/rki/coronawarnapp/test/debugoptions/ui/DebugOptionsFragmentViewModelTest.kt
LukasLechnerDev
dismissed stale reviews from jurajkusnier and mtwalli
via
March 31, 2021 15:57
195b6fd
mtwalli
approved these changes
Mar 31, 2021
Kudos, SonarCloud Quality Gate passed! |
jurajkusnier
approved these changes
Mar 31, 2021
LukasLechnerDev
deleted the
feature/5842-Poster-template-download-and-storage
branch
March 31, 2021 16:07
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements basic poster template download and caching.
Details can be found in the first part of Point 1 from TechSpec Poster Generation.
Not included
How to Test
test_environment.json
from wiki that includesQRCODE_POSTER_TEMPLATE_URL