This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Connect Qr-Code Screen to Organizer Flow (EXPOSUREAPP-5971) #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/corona-warn-app/cwa-app-android into feature/5971-qr-code-repo-connection
|
Kudos, SonarCloud Quality Gate passed! |
AlexanderAlferov
approved these changes
Apr 1, 2021
| private val vm: QrCodeDetailViewModel by cwaViewModels { viewModelFactory } | ||
| private val navArgs by navArgs<QrCodeDetailFragmentArgs>() | ||
|
|
||
| private val vm: QrCodeDetailViewModel by cwaViewModelsAssisted( |
There was a problem hiding this comment.
I think we are trying to streamline it not with "vm", but with "viewModel". Would be nice to rename it 🏷️
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR connects the QrCode Detail Screen with the database and is now called from the "My Qr-Codes" List fragment in the Organizer flow.
To test the changes, go to the Main Menü -> Planen Sie eine Veranstaltung Card -> Press on an entry
If there is no entry yet, go to: Test Menu -> Event Registration -> Events -> Generate Test Trace Locations
Please note: The Qr-Code string is currently still hard coded and will be changed in a follow-up PR.
qr_code_detail_connection.mp4