This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
Create trace locations locally (EXPOSUREAPP-6015) #2717
Merged
LukasLechnerDev
merged 18 commits into
release/2.0.x
from
feature/6015-Create-tracelocations-locally
Mar 31, 2021
Merged
Create trace locations locally (EXPOSUREAPP-6015) #2717
LukasLechnerDev
merged 18 commits into
release/2.0.x
from
feature/6015-Create-tracelocations-locally
Mar 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kolpa
previously approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love getting rid of all the networking ❤️ one small comment about okio usage in lots of places but nothing serious
...androidTest/java/de/rki/coronawarnapp/eventregistration/storage/TraceLocationDatabaseData.kt
Outdated
Show resolved
Hide resolved
...androidTest/java/de/rki/coronawarnapp/eventregistration/storage/TraceLocationDatabaseData.kt
Outdated
Show resolved
Hide resolved
...ava/de/rki/coronawarnapp/test/eventregistration/ui/EventRegistrationTestFragmentViewModel.kt
Outdated
Show resolved
Hide resolved
...ava/de/rki/coronawarnapp/test/eventregistration/ui/EventRegistrationTestFragmentViewModel.kt
Outdated
Show resolved
Hide resolved
...ava/de/rki/coronawarnapp/test/eventregistration/ui/EventRegistrationTestFragmentViewModel.kt
Outdated
Show resolved
Hide resolved
...warnapp/eventregistration/checkins/qrcode/TraceLocationUserInputToTraceLocationMapperTest.kt
Show resolved
Hide resolved
...n-App/src/test/java/de/rki/coronawarnapp/eventregistration/events/TraceLocationMapperTest.kt
Outdated
Show resolved
Hide resolved
...c/test/java/de/rki/coronawarnapp/eventregistration/storage/entity/TraceLocationEntityTest.kt
Outdated
Show resolved
Hide resolved
...st/java/de/rki/coronawarnapp/eventregistration/storage/retention/TraceLocationCleanerTest.kt
Outdated
Show resolved
Hide resolved
.../rki/coronawarnapp/ui/eventregistration/organizer/create/TraceLocationCreateViewModelTest.kt
Outdated
Show resolved
Hide resolved
kolyaopahle
previously approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used the wrong github account to review will approve here so that you get the code owner counter up ^^
…ns-locally' into feature/6015-Create-tracelocations-locally
…locally # Conflicts: # Corona-Warn-App/schemas/de.rki.coronawarnapp.eventregistration.storage.TraceLocationDatabase/1.json # Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/eventregistration/ui/EventRegistrationTestFragmentViewModel.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/EventRegistrationModule.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/eventregistration/attendee/confirm/ConfirmCheckInViewModel.kt
jurajkusnier
previously approved these changes
Mar 31, 2021
Kudos, SonarCloud Quality Gate passed! |
kolyaopahle
approved these changes
Mar 31, 2021
jurajkusnier
approved these changes
Mar 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the latest TechSpec changes regarding event creation & signature validation. See Tech Spec Section TraceLocation Creation
ID
,Cryptographic Seed
,CN Public Key
byteRepresentation
,signature
,guid
TraceLocation
changedSignedTraceLocation
isn't used anymoreTODO:
CN Public Key
once we get the real one