Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Create trace locations locally (EXPOSUREAPP-6015) #2717

Merged

Conversation

LukasLechnerDev
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev commented Mar 30, 2021

This PR implements the latest TechSpec changes regarding event creation & signature validation. See Tech Spec Section TraceLocation Creation

  • Removes the server communication after event creation
  • New database fields for trace location: ID, Cryptographic Seed, CN Public Key
  • Removed database fields: byteRepresentation, signature, guid
  • model TraceLocation changed
  • SignedTraceLocation isn't used anymore

TODO:

  • Replace dummy CN Public Key once we get the real one

@LukasLechnerDev LukasLechnerDev added the maintainers Tag pull requests created by maintainers label Mar 30, 2021
@LukasLechnerDev LukasLechnerDev added this to the 2.0.0 milestone Mar 30, 2021
@LukasLechnerDev LukasLechnerDev requested a review from a team March 30, 2021 12:42
Kolpa
Kolpa previously approved these changes Mar 31, 2021
Copy link
Contributor

@Kolpa Kolpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love getting rid of all the networking ❤️ one small comment about okio usage in lots of places but nothing serious

kolyaopahle
kolyaopahle previously approved these changes Mar 31, 2021
Copy link
Contributor

@kolyaopahle kolyaopahle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used the wrong github account to review will approve here so that you get the code owner counter up ^^

@LukasLechnerDev LukasLechnerDev dismissed stale reviews from kolyaopahle and Kolpa via 62784d2 March 31, 2021 12:15
…locally

# Conflicts:
#	Corona-Warn-App/schemas/de.rki.coronawarnapp.eventregistration.storage.TraceLocationDatabase/1.json
#	Corona-Warn-App/src/deviceForTesters/java/de/rki/coronawarnapp/test/eventregistration/ui/EventRegistrationTestFragmentViewModel.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/eventregistration/EventRegistrationModule.kt
#	Corona-Warn-App/src/main/java/de/rki/coronawarnapp/ui/eventregistration/attendee/confirm/ConfirmCheckInViewModel.kt
jurajkusnier
jurajkusnier previously approved these changes Mar 31, 2021
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.0% 70.0% Coverage
0.0% 0.0% Duplication

@LukasLechnerDev LukasLechnerDev merged commit 3c86de7 into release/2.0.x Mar 31, 2021
@LukasLechnerDev LukasLechnerDev deleted the feature/6015-Create-tracelocations-locally branch March 31, 2021 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants