Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Add Crowd Notifier Public Key for different environments (EXPOSUREAPP-6118) #2729

Merged
merged 9 commits into from
Apr 1, 2021
Merged

Add Crowd Notifier Public Key for different environments (EXPOSUREAPP-6118) #2729

merged 9 commits into from
Apr 1, 2021

Conversation

LukasLechnerDev
Copy link
Contributor

@LukasLechnerDev LukasLechnerDev commented Apr 1, 2021 •
edited
Loading

Adds the crowd notifier public key to our environment setup and stores it in the cnPublicKey field of the TraceLocation database table after creating an event.

See TechSpec

How to test:

  • update test_environments.json (see wiki) so that it includes CROWD_NOTIFIER_PUBLIC_KEY
  • Create trace location via real organizer flow
  • TestMenu -> EventReg -> Show Stored Events
  • Check if created trace location contains proper cnPublicKey

@LukasLechnerDev LukasLechnerDev added the maintainers Tag pull requests created by maintainers label Apr 1, 2021
@LukasLechnerDev LukasLechnerDev added this to the 2.0.0 milestone Apr 1, 2021
@LukasLechnerDev LukasLechnerDev requested a review from a team April 1, 2021 06:43
@LukasLechnerDev LukasLechnerDev changed the title Add cn public key for different environments (EXPOSUREAPP-6118) Add CrowdNotifier public key for different environments (EXPOSUREAPP-6118) Apr 1, 2021
@LukasLechnerDev LukasLechnerDev changed the title Add CrowdNotifier public key for different environments (EXPOSUREAPP-6118) Add Crowd Notifier Public Key for different environments (EXPOSUREAPP-6118) Apr 1, 2021
@LukasLechnerDev LukasLechnerDev force-pushed the feature/6118-Add-cnPublicKey-for-different-environments branch from a8cce8f to b8bd4bc Compare April 1, 2021 07:03
@mtwalli mtwalli self-assigned this Apr 1, 2021
@d4rken d4rken self-requested a review April 1, 2021 07:56
@d4rken d4rken self-assigned this Apr 1, 2021
mtwalli
mtwalli approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@mtwalli mtwalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud
Copy link

sonarcloud bot commented Apr 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit dd3341d into release/2.0.x Apr 1, 2021
@mtwalli mtwalli deleted the feature/6118-Add-cnPublicKey-for-different-environments branch April 1, 2021 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtwalli mtwalli mtwalli approved these changes

@d4rken d4rken d4rken approved these changes

Assignees

@d4rken d4rken

@mtwalli mtwalli

Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@LukasLechnerDev @d4rken @mtwalli