Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Organizer Flow: Add Onboarding Screen to Menu (DEV) #2731

Conversation

axelherbstreith
Copy link
Contributor

@axelherbstreith axelherbstreith commented Apr 1, 2021

Small PR that links the onboarding screen to the QR code list fragment menu

To test it: Access the "Sie planen eine Veranstaltung" Card. Then open the "Information" Button on the Menu. Check if the navigation is working fine

@axelherbstreith axelherbstreith added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers labels Apr 1, 2021
@axelherbstreith axelherbstreith added this to the 2.0.0 milestone Apr 1, 2021
@axelherbstreith axelherbstreith requested a review from a team April 1, 2021 09:09
@harambasicluka harambasicluka self-assigned this Apr 1, 2021
@sonarcloud
Copy link

sonarcloud bot commented Apr 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexanderAlferov AlexanderAlferov self-assigned this Apr 1, 2021
@SamuraiKek
Copy link
Contributor

SamuraiKek commented Apr 1, 2021

The transition between the "My QR-Codes" screen and the info screen is kinda weird. There's a second where the two layouts look merged before the info screen shows up fully. I was actually able to take a screenshot of this so it's pretty noticeable.
Screenshot_20210414-124206

Tested on Nokia 3 (Android 9). It might only be noticeable on slower phones though.

Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, spotted the same problem as @SamuraiKek.

device-2021-04-01-115050.mp4

@axelherbstreith
Copy link
Contributor Author

@SamuraiKek @harambasicluka yes I noticed that too. This seems to be an issue with the TraceLocation List Fragment. All interactions started from this fragment cause this "delay"

E.g.: When duplicating a TraceLocation or navigating to the QR code detail screen:

qr_code_detail_connection.mp4

Would suggest to put the fix in a different PR

Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in and try to fix the problem with the list.

@harambasicluka harambasicluka merged commit 8530116 into release/2.0.x Apr 1, 2021
@harambasicluka harambasicluka deleted the feature/DEV-add-information-screen-to-organizer-flow branch April 1, 2021 10:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers ui Issue related to UI aspects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants