This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Add new test environment TESTER-MOCK + clean up (DEV, EXPOSUREAPP-6138) #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
d4rken
commented
Apr 6, 2021
d4rken
commented
- Additional environment option that was requested
- Remove previously added presence tracing entries that are no longer needed
- Show public keys in test fragment
- Compare with https://github.com/corona-warn-app/cwa-app-android-environments/pull/1
d4rken
changed the title
There was a problem hiding this comment.
Tested, coding looks good. But we need to verify if the downloading still works as @LukasLechnerDev has implemented it.
| @@ -9,8 +9,9 @@ data class EnvironmentState( | |||
| val urlDownload: String, | |||
| val urlVerification: String, | |||
| val urlDataDonation: String, | |||
| val urlQrCodePosterTemplate: String | |||
|
|
|||
| val logUpload: String, | |||
There was a problem hiding this comment.
logUpload => urlLogUpload to be consistent with the other namings?
There was a problem hiding this comment.
Good idea. Fixed it.
LukasLechnerDev
previously approved these changes
Apr 6, 2021
harambasicluka
previously approved these changes
Apr 6, 2021
LukasLechnerDev
dismissed stale reviews from harambasicluka and themself
via
d344f04
LukasLechnerDev
approved these changes
Apr 6, 2021
harambasicluka
approved these changes
Apr 6, 2021
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.