Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Improve CheckIns transitions (DEV) #2768

Merged
merged 8 commits into from
Apr 8, 2021
Merged

Improve CheckIns transitions (DEV) #2768

merged 8 commits into from
Apr 8, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Apr 7, 2021

  • Improve transition from Check-ins Fragment to its destinations
  • this will avoid glitches that was happening before

Testing

Check before and after the changes

@mtwalli mtwalli requested a review from a team April 7, 2021 17:43
@mtwalli mtwalli added maintainers Tag pull requests created by maintainers ui Issue related to UI aspects labels Apr 7, 2021
@mtwalli mtwalli added this to the 2.0.0 milestone Apr 7, 2021
@mtwalli mtwalli changed the title Improve transition from CheckIns to its destinations (Dev) Improve CheckIns transition (DEV) Apr 8, 2021
@mtwalli mtwalli changed the title Improve CheckIns transition (DEV) Improve CheckIns transitions (DEV) Apr 8, 2021
SamuraiKek
SamuraiKek approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested on Nokia 3 (Android 9).

@SamuraiKek SamuraiKek self-assigned this Apr 8, 2021
@axelherbstreith axelherbstreith self-assigned this Apr 8, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

3.4% 3.4% Coverage
0.0% 0.0% Duplication

@mtwalli mtwalli merged commit 4b6f6d9 into release/2.0.x Apr 8, 2021
@mtwalli mtwalli deleted the dev/improve_checkin_transition branch April 8, 2021 14:49
SamuraiKek pushed a commit that referenced this pull request Apr 9, 2021
@mtwalli @harambasicluka @SamuraiKek
Improve CheckIns transitions (DEV) (#2768)
3d8901d 
* Improve transition from CheckIns to its destinations

* Polishing

* Update trace_location_organizer_qr_code_detail_fragment.xml

Co-authored-by: harambasicluka <64483219+harambasicluka@users.noreply.github.com>
fynngodau pushed a commit to fynngodau/cwa-app-android that referenced this pull request Apr 10, 2021
@mtwalli @harambasicluka @fynngodau
Improve CheckIns transitions (DEV) (corona-warn-app#2768)
58de49e 
* Improve transition from CheckIns to its destinations

* Polishing

* Update trace_location_organizer_qr_code_detail_fragment.xml

Co-authored-by: harambasicluka <64483219+harambasicluka@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@axelherbstreith axelherbstreith axelherbstreith approved these changes

@SamuraiKek SamuraiKek SamuraiKek approved these changes

Assignees

@SamuraiKek SamuraiKek

@axelherbstreith axelherbstreith

Labels
maintainers Tag pull requests created by maintainers ui Issue related to UI aspects
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mtwalli @SamuraiKek @axelherbstreith @harambasicluka