This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
Improve TraceLocations transitions (DEV) #2769
Merged
harambasicluka
merged 8 commits into
release/2.0.x
from
dev/improve_tracelocations_transition
Apr 8, 2021
Merged
Improve TraceLocations transitions (DEV) #2769
harambasicluka
merged 8 commits into
release/2.0.x
from
dev/improve_tracelocations_transition
Apr 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwalli
added
ui
Issue related to UI aspects
maintainers
Tag pull requests created by maintainers
labels
Apr 8, 2021
mtwalli
changed the title
Improve TraceLocations transitions
Improve TraceLocations transitions (DEV)
Apr 8, 2021
SamuraiKek
previously approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Transitions working as intended. Tested on Nokia 3 (Android 9)
axelherbstreith
previously approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution 👍
axelherbstreith
approved these changes
Apr 8, 2021
SamuraiKek
approved these changes
Apr 8, 2021
Kudos, SonarCloud Quality Gate passed! |
SamuraiKek
pushed a commit
that referenced
this pull request
Apr 9, 2021
* Improve transition * Animate to poster * From Home to TraceLocations * Fix merge issue * lint Co-authored-by: harambasicluka <64483219+harambasicluka@users.noreply.github.com>
fynngodau
pushed a commit
to fynngodau/cwa-app-android
that referenced
this pull request
Apr 10, 2021
* Improve transition * Animate to poster * From Home to TraceLocations * Fix merge issue * lint Co-authored-by: harambasicluka <64483219+harambasicluka@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Check before and after