Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Improve TraceLocations transitions (DEV) #2769

Merged
merged 8 commits into from
Apr 8, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Apr 8, 2021

  • Improve Trace Locations screen transitions to its destinations to fix glitches

Testing

Check before and after

@mtwalli mtwalli added ui Issue related to UI aspects maintainers Tag pull requests created by maintainers labels Apr 8, 2021
@mtwalli mtwalli added this to the 2.0.0 milestone Apr 8, 2021
@mtwalli mtwalli requested a review from a team April 8, 2021 06:21
@mtwalli mtwalli changed the title Improve TraceLocations transitions Improve TraceLocations transitions (DEV) Apr 8, 2021
SamuraiKek
SamuraiKek previously approved these changes Apr 8, 2021
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Transitions working as intended. Tested on Nokia 3 (Android 9)

axelherbstreith
axelherbstreith previously approved these changes Apr 8, 2021
Copy link
Contributor

@axelherbstreith axelherbstreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution 👍

@mtwalli mtwalli dismissed stale reviews from axelherbstreith and SamuraiKek via 66c1275 April 8, 2021 12:02
@sonarcloud
Copy link

sonarcloud bot commented Apr 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@harambasicluka harambasicluka merged commit 83ed59b into release/2.0.x Apr 8, 2021
@harambasicluka harambasicluka deleted the dev/improve_tracelocations_transition branch April 8, 2021 13:08
SamuraiKek pushed a commit that referenced this pull request Apr 9, 2021
* Improve transition

* Animate to poster

* From  Home  to TraceLocations

* Fix merge issue

* lint

Co-authored-by: harambasicluka <64483219+harambasicluka@users.noreply.github.com>
fynngodau pushed a commit to fynngodau/cwa-app-android that referenced this pull request Apr 10, 2021
* Improve transition

* Animate to poster

* From  Home  to TraceLocations

* Fix merge issue

* lint

Co-authored-by: harambasicluka <64483219+harambasicluka@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers ui Issue related to UI aspects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants