Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Exposure Logging: text missing when, bluetooth disabled (EXPOSUREAPP-6190) #2779

Merged

Conversation

SamuraiKek
Copy link
Contributor

Small bug fix that won't make the period logged body text disappear when bluetooth is disabled.

  • Go to exposure logging, check out the period logged title, subtitle and two blocks of text below it.
  • Disable bluetooth and check that the text is still there.

@SamuraiKek SamuraiKek added bug Something isn't working maintainers Tag pull requests created by maintainers labels Apr 8, 2021
@SamuraiKek SamuraiKek added this to the 2.0.0 milestone Apr 8, 2021
@SamuraiKek SamuraiKek requested a review from a team April 8, 2021 10:55
@harambasicluka harambasicluka self-assigned this Apr 9, 2021
@axelherbstreith axelherbstreith self-assigned this Apr 9, 2021
harambasicluka
harambasicluka previously approved these changes Apr 9, 2021
Copy link
Contributor

@harambasicluka harambasicluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good, just increase the margin by a bit :)

chris-cwa
chris-cwa previously approved these changes Apr 9, 2021
@SamuraiKek SamuraiKek dismissed stale reviews from chris-cwa and harambasicluka via 3c51001 April 9, 2021 14:36
@SamuraiKek
Copy link
Contributor Author

Addressed Luka's comment by adding a top margin to the "Period Logged" title.

@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@harambasicluka harambasicluka merged commit 1646344 into release/2.0.x Apr 9, 2021
@harambasicluka harambasicluka deleted the fix/6190-text-missing-bl-off-expo-logging branch April 9, 2021 14:47
fynngodau pushed a commit to fynngodau/cwa-app-android that referenced this pull request Apr 10, 2021
…6190) (corona-warn-app#2779)

* Period logged description no longer disappearing when bluetooth disabled.

* Added a bit more margin to the Period Logged title.

Co-authored-by: harambasicluka <64483219+harambasicluka@users.noreply.github.com>
Co-authored-by: chris-cwa <69595386+chris-cwa@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants