This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
Exposure Logging: text missing when, bluetooth disabled (EXPOSUREAPP-6190) #2779
Merged
harambasicluka
merged 8 commits into
release/2.0.x
from
fix/6190-text-missing-bl-off-expo-logging
Apr 9, 2021
Merged
Exposure Logging: text missing when, bluetooth disabled (EXPOSUREAPP-6190) #2779
harambasicluka
merged 8 commits into
release/2.0.x
from
fix/6190-text-missing-bl-off-expo-logging
Apr 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuraiKek
added
bug
Something isn't working
maintainers
Tag pull requests created by maintainers
labels
Apr 8, 2021
harambasicluka
previously approved these changes
Apr 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good, just increase the margin by a bit :)
chris-cwa
previously approved these changes
Apr 9, 2021
SamuraiKek
dismissed stale reviews from chris-cwa and harambasicluka
via
April 9, 2021 14:36
3c51001
Addressed Luka's comment by adding a top margin to the "Period Logged" title. |
chris-cwa
approved these changes
Apr 9, 2021
Kudos, SonarCloud Quality Gate passed! |
harambasicluka
approved these changes
Apr 9, 2021
fynngodau
pushed a commit
to fynngodau/cwa-app-android
that referenced
this pull request
Apr 10, 2021
…6190) (corona-warn-app#2779) * Period logged description no longer disappearing when bluetooth disabled. * Added a bit more margin to the Period Logged title. Co-authored-by: harambasicluka <64483219+harambasicluka@users.noreply.github.com> Co-authored-by: chris-cwa <69595386+chris-cwa@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small bug fix that won't make the period logged body text disappear when bluetooth is disabled.