Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix QR code timezone (EXPOSUREAPP-6249) #2786

Merged
merged 5 commits into from
Apr 9, 2021
Merged

Fix QR code timezone (EXPOSUREAPP-6249) #2786

merged 5 commits into from
Apr 9, 2021

Conversation

jurajkusnier
Copy link
Contributor

PR fixes issue where QR code time for event moved 2 hours forward

@jurajkusnier jurajkusnier added bug Something isn't working maintainers Tag pull requests created by maintainers labels Apr 9, 2021
@jurajkusnier jurajkusnier added this to the 2.0.0 milestone Apr 9, 2021
@jurajkusnier jurajkusnier requested a review from a team April 9, 2021 07:27
@codejus codejus mentioned this pull request Apr 9, 2021
Closed
@d4rken d4rken self-assigned this Apr 9, 2021
@d4rken d4rken self-requested a review April 9, 2021 08:02
@MikeMcC399
Copy link
Contributor

I successfully verified the fix in this PR linked to issue #2761.

Verification

  1. Open CWA, scroll down to "CREATE QR CODE" and select it
  2. Tap on "+ QR CODE"
  3. Tap on "Cultural event"
  4. Enter a description text and a place text
  5. Define start and end times and make a note of them
  6. Tap "SAVE"
  7. Examine the screen with the header "My QR Codes" and compare to the times entered in step 5.

Expected behavior

The times entered should be the same as the times later displayed after a QR code for an event is created. ✔️

Environment

  • Device name: Google Pixel 3a emulator
  • Android version: 11

d4rken
d4rken approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@d4rken d4rken left a comment •
edited by jurajkusnier
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Can we add a unit test for this?

image

image

@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@jurajkusnier
Copy link
Contributor Author

👍

Can we add a unit test for this?

This should be covered by an instrumentation test in the following PR

@jurajkusnier jurajkusnier merged commit ee2d71b into release/2.0.x Apr 9, 2021
@jurajkusnier jurajkusnier deleted the fix/6249-qr_code_time branch April 9, 2021 12:45
fynngodau pushed a commit to fynngodau/cwa-app-android that referenced this pull request Apr 10, 2021
@jurajkusnier @fynngodau
Fix QR code timezone (EXPOSUREAPP-6249) (corona-warn-app#2786)
4dba464 
* Use default timezone

* Remove unused imports
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chris-cwa chris-cwa chris-cwa approved these changes

@d4rken d4rken d4rken approved these changes

Assignees

@d4rken d4rken

Labels
bug Something isn't working maintainers Tag pull requests created by maintainers
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jurajkusnier @MikeMcC399 @d4rken @chris-cwa