This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Extend poster testability (EXPOSUREAPP-6308) #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtwalli
added
ui
…ub.com/corona-warn-app/cwa-app-android into feature/6308-extend_poster_testaiblity
d4rken
approved these changes
Apr 12, 2021
| @Suppress("BlockingMethodInNonBlockingContext") | ||
| fun createPDF(view: View) = launch(context = dispatcher.IO) { | ||
| try { | ||
| val weakViewRef = WeakReference(view) // Accessing view in background thread |
There was a problem hiding this comment.
Not sure if this works or if the view a function parameters will still cause a reference to be held by the coroutine due to having theoretical access to it in this scope.
Not a blocker for me in a test fragment.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
presencetracingQrCodeDetailsFragmentModulefromtestto actual Moduledevice-2021-04-09-171013.mp4