This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
Prevent matching our own CheckIns (EXPOSUREAPP-6305) #2797
Merged
harambasicluka
merged 5 commits into
release/2.0.x
from
fix/6305-pt-matching-no-self-warn
Apr 12, 2021
Merged
Prevent matching our own CheckIns (EXPOSUREAPP-6305) #2797
harambasicluka
merged 5 commits into
release/2.0.x
from
fix/6305-pt-matching-no-self-warn
Apr 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he database and skipping them during matching.
d4rken
added
bug
Something isn't working
maintainers
Tag pull requests created by maintainers
labels
Apr 9, 2021
chiljamgossow
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way of handling it will also obscure other people's warnings. I suppose this is accepted.
@@ -262,13 +262,32 @@ class OverlapTest : BaseTest() { | |||
traceWarningPackageId = id | |||
)!!.roundedMinutes shouldBe 5 | |||
} | |||
|
|||
@Test | |||
fun `returns null if it matches our own ssubmitted CheckIn`() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo submitted
jurajkusnier
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bug
Something isn't working
maintainers
Tag pull requests created by maintainers
prio
PRs to review first.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent matching our own CheckIns, by marking submitted CheckIns in the database and skipping them during matching.