Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Prevent matching our own CheckIns (EXPOSUREAPP-6305) #2797

Merged
merged 5 commits into from
Apr 12, 2021

Conversation

d4rken
Copy link
Member

@d4rken d4rken commented Apr 9, 2021

Prevent matching our own CheckIns, by marking submitted CheckIns in the database and skipping them during matching.

…he database and skipping them during matching.
@d4rken d4rken added bug Something isn't working maintainers Tag pull requests created by maintainers labels Apr 9, 2021
@d4rken d4rken added this to the 2.0.0 milestone Apr 9, 2021
@d4rken d4rken marked this pull request as ready for review April 9, 2021 19:00
@d4rken d4rken requested a review from a team April 9, 2021 19:00
@d4rken d4rken added the prio PRs to review first. label Apr 12, 2021
@chiljamgossow chiljamgossow self-assigned this Apr 12, 2021
Copy link
Contributor

@chiljamgossow chiljamgossow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way of handling it will also obscure other people's warnings. I suppose this is accepted.

@@ -262,13 +262,32 @@ class OverlapTest : BaseTest() {
traceWarningPackageId = id
)!!.roundedMinutes shouldBe 5
}

@Test
fun `returns null if it matches our own ssubmitted CheckIn`() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo submitted

Copy link
Contributor

@jurajkusnier jurajkusnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jurajkusnier jurajkusnier self-assigned this Apr 12, 2021
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

65.5% 65.5% Coverage
0.0% 0.0% Duplication

@harambasicluka harambasicluka merged commit 654bdb6 into release/2.0.x Apr 12, 2021
@harambasicluka harambasicluka deleted the fix/6305-pt-matching-no-self-warn branch April 12, 2021 14:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants