Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Profile screen (EXPOSUREAPP-6029) #2964

Merged
merged 69 commits into from
Apr 29, 2021
Merged

Profile screen (EXPOSUREAPP-6029) #2964

merged 69 commits into from
Apr 29, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Apr 26, 2021 •
edited
Loading

  • Creates Profile Qr Code screen
  • Simple V-Card format string replacement

TODO

  • generate Qr code from v-card format
  • Add some unit tests

mtwalli added 30 commits April 15, 2021 17:04
@mtwalli
Create rat profile nav graph skeleton
88e3511
@mtwalli
Rename ids
a715ac8
@mtwalli
Wire card logic
b0a92d1
@mtwalli
Adjust strings
d88d65f
@mtwalli
Open profile card
35ce7bd
@mtwalli
Create Profile settings
d99b3fa
@mtwalli
Navigation skeleton
c2261e8
@mtwalli
Wire navigation
249fbbb
@mtwalli
Adjust navigation
1ae3f30
@mtwalli
Fix test
341460e
@mtwalli
Create Profile screen
11e0ff8
@mtwalli
do navigate
3e13c66
@mtwalli
Set dummy profile
9287707
@mtwalli
Profile validation
9f72215
@mtwalli
Update SubmissionDispatcherViewModel.kt
926e5c6
@mtwalli
Extract strings
64020fa
@mtwalli
Navigation
a338ee0
@mtwalli
Extra lines
5606f3d
@mtwalli
Adjust navigation
a384f01
@mtwalli
lint
45684ba
@mtwalli
Merge branch 'release/2.2.x' into feature/6025-rat-create-profile-card
3940cc0
@mtwalli
Merge branch 'release/2.2.x' into feature/6025-rat-create-profile-card
921ea9e
@mtwalli
Merge branch 'release/2.2.x' into feature/6025-rat-create-profile-card
4ca1464
@mtwalli
Add new fields
0ba04f9
@mtwalli
rename to zip code
e0d85a4
@mtwalli
Update strings.xml
b1ed6a5
@mtwalli
fix layout
d8a5aa7
@mtwalli
Bind new fields
11008a2
@mtwalli
Show date picker
5a08522
@mtwalli
Create RATProfileCreateFragmentViewModelTest.kt
a240a6b
@mtwalli mtwalli marked this pull request as ready for review April 28, 2021 14:04
@mtwalli mtwalli requested review from a team April 28, 2021 14:04
janetback
janetback previously approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

@axelherbstreith axelherbstreith self-assigned this Apr 28, 2021
@AlexanderAlferov AlexanderAlferov self-assigned this Apr 29, 2021
AlexanderAlferov
AlexanderAlferov previously approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@AlexanderAlferov AlexanderAlferov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

21.2% 21.2% Coverage
0.0% 0.0% Duplication

axelherbstreith
axelherbstreith approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@axelherbstreith axelherbstreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice! Great work 👍

@harambasicluka harambasicluka merged commit 2267bfb into release/2.2.x Apr 29, 2021
@harambasicluka harambasicluka deleted the feature/6029-profile-screen branch April 29, 2021 12:31
janetback
janetback reviewed Apr 29, 2021
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

janetback
janetback reviewed Apr 29, 2021
View reviewed changes
Copy link
Contributor

@janetback janetback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UA reviewed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janetback janetback janetback left review comments

@axelherbstreith axelherbstreith axelherbstreith approved these changes

@AlexanderAlferov AlexanderAlferov AlexanderAlferov approved these changes

Assignees

@AlexanderAlferov AlexanderAlferov

@axelherbstreith axelherbstreith

Labels
maintainers Tag pull requests created by maintainers text change PRs with text changes. ui Issue related to UI aspects
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mtwalli @AlexanderAlferov @janetback @axelherbstreith @harambasicluka