This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Change text for days since installation (EXPOSUREAPP-6574) #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiljamgossow
added
maintainers
|
May need to be changes to |
|
We'll get a translation delivery, but it is too late for this PR. I have overseen it. Need to ship it with |
chiljamgossow
force-pushed
the
feature/6574-today
branch
from
4e1fa9f to
be023b7
Compare
mtwalli
approved these changes
Apr 28, 2021
|
|
||
| val daysSinceInstallation: Long get() = (System.currentTimeMillis() - installTime).roundUpMsToDays() | ||
| val today: LocalDate | ||
| get() = Instant.now().toLocalDateUserTz() |
There was a problem hiding this comment.
maybe timeStamper.nowUTC ?
| when (daysSinceInstallation) { | ||
| 0 -> context.getString(R.string.risk_card_body_installation_today) | ||
| 1 -> context.getString(R.string.risk_card_body_installation_yesterday) | ||
| else -> context.getString(R.string.risk_card_body_days_since_installation).format(daysSinceInstallation) |
There was a problem hiding this comment.
context.getString(R.string.risk_card_body_days_since_installation,daysSinceInstallation) could format directly ?
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New text if installation today or yesterday
Changed calculation to account for date changes (not 24h intervals) based on user time zone