Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Timber - Third party notices patch #340

Merged
merged 4 commits into from
Jun 10, 2020
Merged

Conversation

AlexanderAlferov
Copy link
Contributor

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • If this PR comes from a fork, please Allow edits from maintainers
  • Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
  • Link your Pull Request to an issue (if applicable)
  • Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
  • Make sure that your PR does not contain changes in strings.xml (see issue Text and Translation Contributions #72)
  • Make sure that your PR does not contain compiled sources (already set by the default .gitignore) and / or binary files

Description

@AlexanderAlferov AlexanderAlferov requested review from oemerb and a team June 10, 2020 09:35
oemerb
oemerb previously approved these changes Jun 10, 2020
harambasicluka
harambasicluka previously approved these changes Jun 10, 2020
@harambasicluka harambasicluka added the maintainers Tag pull requests created by maintainers label Jun 10, 2020
@jakobmoellerdev jakobmoellerdev marked this pull request as draft June 10, 2020 13:06
@jakobmoellerdev jakobmoellerdev changed the title Third party notices patch Timber - Third party notices patch Jun 10, 2020
@jakobmoellerdev jakobmoellerdev marked this pull request as ready for review June 10, 2020 14:42
@jakobmoellerdev jakobmoellerdev dismissed stale reviews from harambasicluka and oemerb via 7a36d12 June 10, 2020 14:42
@jakobmoellerdev jakobmoellerdev merged commit b0d6a63 into dev Jun 10, 2020
@jakobmoellerdev jakobmoellerdev deleted the THIRD-PARTY-NOTICES-patch branch June 10, 2020 14:42
@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jakobmoellerdev pushed a commit that referenced this pull request Aug 7, 2020
…tory-refactoring

Removed unused notifications and bound notification switch to os
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants