This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Refactor scan screen to support all certificates (EXPOSUREAPP-7686) #3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/recovery/core/certificate/RecoveryDccV1.kt
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/recovery/core/certificate/RecoveryDccV1.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/recovery/core/storage/RecoveryCertificateContainer.kt
# Conflicts: # Corona-Warn-App/src/test/java/de/rki/coronawarnapp/covidcertificate/vaccination/core/repository/VaccinationRepositoryTest.kt
Base automatically changed from
feature/7676-recovery-extractor
to
release/2.5.x
June 17, 2021 11:44
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/common/certificate/DccV1Parser.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/test/core/TestCertificateRepository.kt # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/vaccination/ui/scan/VaccinationQrCodeScanViewModel.kt
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/test/core/TestCertificateRepository.kt
# Conflicts: # Corona-Warn-App/src/main/java/de/rki/coronawarnapp/covidcertificate/person/ui/overview/PersonOverviewFragment.kt
mtwalli
reviewed
Jun 17, 2021
|
|
||
| private val binding: FragmentScanQrCodeBinding by viewBinding() | ||
| private var showsPermissionDialog = false | ||
|
|
||
| val requestPermissionLauncher = |
| ).show() | ||
| ScanQrCode -> doNavigate( | ||
| PersonOverviewFragmentDirections.actionPersonOverviewFragmentToDccQrCodeScanFragment() | ||
| ) |
There was a problem hiding this comment.
Can we apply the same transition as in CheckInsFragment ?
|
Kudos, SonarCloud Quality Gate passed! |
mtwalli
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
Created a ticket for polishing https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-7984
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds navigation, new permission api
test and recovery are incomplete due missing screen/ repo extension
vaccination works
merge after #3444