Add Local Incidence Card to Statistics (EXPOSUREAPP-7446)

[kolyaopahle]

Description

This PR Adds the local incidence card for the new local statistics feature, note that there is no logic in place to actually display the card at the moment this will be done in a follow up PR

[NataliaLemmerth]

UA approved

[jurajkusnier]

I got crash after removing Local Incidence Card

    java.lang.IllegalStateException: Two different ViewHolders have the same stable ID. Stable IDs in your adapter MUST BE unique and SHOULD NOT change.
    ViewHolder 1:LocalIncidenceCard{312f8db position=2 id=8, oldPos=-1, pLpos:-1 not recyclable(1)} 
     View Holder 2:LocalIncidenceCard{ddbd4cd position=1 id=8, oldPos=-1, pLpos:-1} androidx.recyclerview.widget.RecyclerView{afd4cff VFED..... ......ID 0,269-1080,1241 #7f0a06d7 app:id/statistics_recyclerview}, adapter:de.rki.coronawarnapp.statistics.ui.homecards.StatisticsCardAdapter@9e5d0c4, layout:de.rki.coronawarnapp.statistics.ui.homecards.StatisticsLayoutManager@80dcbad, context:de.rki.coronawarnapp.ui.main.MainActivity@a39276d

[jurajkusnier]

Doesn't meet the Acceptance Criteria:

• The user can add up to 5 additional tiles for local incidences. As long as less than 5 tiles have been added, the tile shows a button to add a new local incidence

The code is already there but is not used. Something like this should work:

// HomeFragmentViewModel.kt, line 203 
data = statsData.copy(
   items = mutableListOf(AddStatsItem(isEnabled = statsData.items.filterIsInstance<LocalIncidenceStats>().size < 5))
                                .plus(statsData.items)
                        ),

[jurajkusnier]

Doesn't meet the Acceptance Criteria:

• if a county was selected, a new tile for the selected county is added left to the latest added local incidence tile. The first local incidence tile is added left to the national incidence tile

[kolyaopahle]

I got crash after removing Local Incidence Card

    java.lang.IllegalStateException: Two different ViewHolders have the same stable ID. Stable IDs in your adapter MUST BE unique and SHOULD NOT change.
    ViewHolder 1:LocalIncidenceCard{312f8db position=2 id=8, oldPos=-1, pLpos:-1 not recyclable(1)} 
     View Holder 2:LocalIncidenceCard{ddbd4cd position=1 id=8, oldPos=-1, pLpos:-1} androidx.recyclerview.widget.RecyclerView{afd4cff VFED..... ......ID 0,269-1080,1241 #7f0a06d7 app:id/statistics_recyclerview}, adapter:de.rki.coronawarnapp.statistics.ui.homecards.StatisticsCardAdapter@9e5d0c4, layout:de.rki.coronawarnapp.statistics.ui.homecards.StatisticsLayoutManager@80dcbad, context:de.rki.coronawarnapp.ui.main.MainActivity@a39276d

weird, this has not happened for me during testing, will investigate

[d4rken]

Looking better every day 😁.
Found a few inconsistencies we need to check out.

[jurajkusnier]

one minor thing: AddCard should be probably completely disabled when there is more than 5 LocalIncidenceCard. So also the ripple effect shouldn't be there.

[jurajkusnier]

The positive trend icon should be green and the negative trend icon should be red, like the rest of the cards. But I see the trend icon only in grey color.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

9.7% Coverage
0.0% Duplication