Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Added exception handler for UnknownHostException's #412

Merged
merged 2 commits into from
Jun 12, 2020

Conversation

kolyaopahle
Copy link
Contributor

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • If this PR comes from a fork, please Allow edits from maintainers
  • Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
  • Link your Pull Request to an issue (if applicable)
  • Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
  • Make sure that your PR does not contain changes in strings.xml (see issue Text and Translation Contributions #72)
  • Make sure that your PR does not contain compiled sources (already set by the default .gitignore) and / or binary files

Description

This PR rewrites the UnknownHostException into a CwaUnknownHostException which is properly handled by the error handling stack

Signed-off-by: Kolya Opahle <k.opahle@sap.com>
Signed-off-by: Kolya Opahle <k.opahle@sap.com>
@kolyaopahle kolyaopahle added backend Issues related to internal work not directly correlated to UI interaction maintainers Tag pull requests created by maintainers labels Jun 12, 2020
@kolyaopahle kolyaopahle requested review from jakobmoellerdev and a team June 12, 2020 10:30
@jakobmoellerdev jakobmoellerdev merged commit dcf8831 into dev Jun 12, 2020
@jakobmoellerdev jakobmoellerdev deleted the fix/unknown-host-ex-handling branch June 12, 2020 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend Issues related to internal work not directly correlated to UI interaction maintainers Tag pull requests created by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants