Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Fix re-arranging issue of Vax certs that have the same vaccinationOn (EXPOSUREAPP-8756) #4136

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Fix re-arranging issue of Vax certs that have the same vaccinationOn (EXPOSUREAPP-8756) #4136

merged 2 commits into from
Sep 29, 2021

Conversation

mtwalli
Copy link
Contributor

@mtwalli mtwalli commented Sep 28, 2021 •
edited
Loading

@mtwalli mtwalli added bug Something isn't working maintainers Tag pull requests created by maintainers labels Sep 28, 2021
@mtwalli mtwalli added this to the 2.11.0 milestone Sep 28, 2021
@mtwalli mtwalli requested a review from a team September 28, 2021 18:47
@mtwalli mtwalli mentioned this pull request Sep 28, 2021
Closed
3 tasks
@mtwalli mtwalli added the prio PRs to review first. label Sep 28, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

46.7% 46.7% Coverage
0.0% 0.0% Duplication

@axelherbstreith axelherbstreith self-assigned this Sep 29, 2021
axelherbstreith
axelherbstreith approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@axelherbstreith axelherbstreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎲

@MikeMcC399
Copy link
Contributor

@mtwalli
This fixes the issue. Thank you! 👍🏻

I verified by scanning in 4 certificates in the order that I received them:

Schema Number / Series Order received Order shown (top = 1)
v1.0.0 1/2 1 4
v1.3.0 2/2 2 2
v1.3.0 2/2 3 1
v1.3.0 1/2 4 3

The latest certificate (v1.3.0 2/2) is marked with "Currently used certificate" and is shown at the top of the list. Selecting any of the certificates in the list and then returning to the list does not affect the order that the certificates are shown in.

vaccination certificate order

SamuraiKek
SamuraiKek approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@SamuraiKek SamuraiKek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SamuraiKek SamuraiKek self-assigned this Sep 29, 2021
@mtwalli mtwalli added the author merge PR to be merged by author label Sep 29, 2021
@mtwalli mtwalli merged commit 68c4f88 into release/2.11.x Sep 29, 2021
@mtwalli mtwalli deleted the fix/8756-cert-ordering branch September 29, 2021 10:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@axelherbstreith axelherbstreith axelherbstreith approved these changes

@SamuraiKek SamuraiKek SamuraiKek approved these changes

Assignees

@SamuraiKek SamuraiKek

@axelherbstreith axelherbstreith

Labels
author merge PR to be merged by author bug Something isn't working maintainers Tag pull requests created by maintainers prio PRs to review first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtwalli @MikeMcC399 @SamuraiKek @axelherbstreith